TrueCloudLab/contract-coverage-primer
22
0
Fork 2
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity

Create an example contract with multiple methods #7

Merged
fyrchik merged 4 commits from elebedeva/contract-coverage-primer:example-contract into master 2024-09-04 19:51:22 +00:00
Conversation 2 Commits 4 Files changed 6 +696
elebedeva commented 2023-07-31 11:19:17 +00:00
Member
Copy link

Close #1

Adding an example contract with PutNumber() and GetNumber() methods.

Close #1 Adding an example contract with `PutNumber()` and `GetNumber()` methods.
requested review from fyrchik 2023-07-31 11:19:59 +00:00
elebedeva changed title from Created an example contract with two methods #1 to Created an example contract with two methods 2023-07-31 11:20:53 +00:00
acid-ant commented 2023-07-31 12:41:20 +00:00
Member
Copy link

Is there a related issue? If this PR close it, could you mention it in description?

Is there a related issue? If this PR close it, could you mention it in description?
acid-ant commented 2023-07-31 12:42:18 +00:00
Member
Copy link

It is common practice to write commit msg imperatively: Created -> Create.

It is common practice to write commit msg imperatively: Created -> Create.
elebedeva changed title from Created an example contract with two methods to [#1] Create an example contract with multiple methods 2023-07-31 12:49:07 +00:00
fyrchik reviewed 2023-07-31 14:51:40 +00:00
go.mod Outdated
@ -0,0 +2,4 @@
go 1.20
require github.com/nspcc-dev/neo-go/pkg/interop v0.0.0-20230728171209-3bbb21bf8f38
fyrchik commented 2023-07-31 14:51:40 +00:00
Owner
Copy link

It is better to depend on the neo-go version: interop version is tightly coupled with the compiler version (the neo-go itself will be a dependency after we add tests). Maybe add simple test in this PR?

It is better to depend on the `neo-go` version: interop version is tightly coupled with the compiler version (the neo-go itself will be a dependency after we add tests). Maybe add simple test in this PR?
elebedeva commented 2023-07-31 16:15:57 +00:00
Author
Member
Copy link

I've added a simple test and made sure the main dependency is neo-go.

I've added a simple test and made sure the main dependency is neo-go.
fyrchik approved these changes 2023-07-31 14:51:50 +00:00
requested review from fyrchik 2023-07-31 15:35:27 +00:00
acid-ant changed title from [#1] Create an example contract with multiple methods to Create an example contract with multiple methods 2023-08-01 06:01:16 +00:00
aarifullin approved these changes 2023-08-01 09:07:20 +00:00
aarifullin left a comment
Member
Copy link

LGTM

LGTM
elebedeva force-pushed example-contract from 2049d860f0 to 72578fc4be 2023-08-01 09:28:49 +00:00 Compare
acid-ant approved these changes 2023-08-01 09:46:54 +00:00
fyrchik approved these changes 2023-08-01 10:41:57 +00:00
fyrchik merged commit 72578fc4be into master 2023-08-01 10:42:02 +00:00
elebedeva deleted branch example-contract 2023-08-01 13:16:54 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
acid-ant
fyrchik
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/contract-coverage-primer#7
No description provided.
Delete branch "elebedeva/contract-coverage-primer:example-contract"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?