TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Scrub: TC bit is always set (#3001)

Browse source 
miekg/dns recently became more aggressive in setting TC; anything that's
chopped of a response results in TC. Amend the tests. Disputable if
these TC checks still add something.

Signed-off-by: Miek Gieben <miek@miek.nl>
This commit is contained in:
Miek Gieben 2019-07-12 12:33:27 +00:00 • committed by GitHub
parent 69a2397bf5
commit 2213a12d21
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
request/request_test.go
View file

@ -98,8 +98,8 @@ func TestRequestScrubExtra(t *testing.T) {
if want, got := req.Size(), reply.Len(); want < got { if want, got := req.Size(), reply.Len(); want < got {
t.Errorf("Want scrub to reduce message length below %d bytes, got %d bytes", want, got) t.Errorf("Want scrub to reduce message length below %d bytes, got %d bytes", want, got)
} }
if reply.Truncated { if !reply.Truncated {
t.Errorf("Want scrub to not set truncated bit") t.Errorf("Want scrub to set truncated bit")
} }
} }
@ -120,8 +120,8 @@ func TestRequestScrubExtraEdns0(t *testing.T) {
if want, got := req.Size(), reply.Len(); want < got { if want, got := req.Size(), reply.Len(); want < got {
t.Errorf("Want scrub to reduce message length below %d bytes, got %d bytes", want, got) t.Errorf("Want scrub to reduce message length below %d bytes, got %d bytes", want, got)
} }
if reply.Truncated { if !reply.Truncated {
t.Errorf("Want scrub to not set truncated bit") t.Errorf("Want scrub to set truncated bit")
} }
} }
@ -146,8 +146,8 @@ func TestRequestScrubExtraRegression(t *testing.T) {
if want, got := req.Size(), reply.Len(); want < got { if want, got := req.Size(), reply.Len(); want < got {
t.Errorf("Want scrub to reduce message length below %d bytes, got %d bytes", want, got) t.Errorf("Want scrub to reduce message length below %d bytes, got %d bytes", want, got)
} }
if reply.Truncated { if !reply.Truncated {
t.Errorf("Want scrub to not set truncated bit") t.Errorf("Want scrub to set truncated bit")
} }
} }