TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

- review BUG related doc for Health and Premotheus after change of behavior to be compatible with reload feature. (#1790)

Browse source
This commit is contained in:
Francois Tur 2018-05-09 10:09:06 -04:00 • committed by Miek Gieben
parent b9f0d55fc9
commit 30309861c5
2 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
plugin/health/README.md
View file

@ -93,3 +93,10 @@ Set a lameduck duration of 1 second:
} }
} }
~~~ ~~~
## Bugs
When reloading, the Health handler is stopped before the new server instance is started.
If that new server fails to start, then the initial server instance is still available and DNS queries still served,
but Health handler stays down.
Health will not reply HTTP request until a successful reload or a complete restart of CoreDNS.

6
plugin/metrics/README.md
View file

@ -71,5 +71,7 @@ then:
## Bugs ## Bugs
When reloading, we keep the handler running, meaning that any changes to the handler's address When reloading, the Prometheus handler is stopped before the new server instance is started.
aren't picked up. You'll need to restart CoreDNS for that to happen. If that new server fails to start, then the initial server instance is still available and DNS queries still served,
but Prometheus handler stays down.
Prometheus will not reply HTTP request until a successful reload or a complete restart of CoreDNS.