Commit graph

2870 commits

Author SHA1 Message Date
Stefan Budeanu
f798d18bdd Fix context passing (#2681) 2019-03-13 18:08:33 +00:00
Yong Tang
26e4026ec1 Add GO111MODULE=off for go get manifest-tool (#2691)
to fix issue #2689

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2019-03-13 18:07:54 +00:00
Rajveer Malviya
6a07e6dcd1 modules: run go mod tidy (#2687) 2019-03-13 08:02:59 +00:00
Miek Gieben
5cff7d5790
Remove etcd unit testing from travis (#2672)
* Remove etcd unit testing from travis

Remove these from the travis unit testing. (to speed up travis)

See #2671

Signed-off-by: Miek Gieben <miek@miek.nl>

* Add build tag

Signed-off-by: Miek Gieben <miek@miek.nl>
2019-03-13 07:33:38 +00:00
Yong Tang
e9ed70cfbe Add $GOPATH/pkg/mod to Travis CI cache (#2686)
in order to speed up the go mod

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2019-03-13 07:33:10 +00:00
Miek Gieben
d652f72fa7
plugin/metadata: tweak the docs a little (#2685)
Add a simpler example that returns a static string the for metadata.

Signed-off-by: Miek Gieben <miek@miek.nl>
2019-03-13 07:26:29 +00:00
Miek Gieben
d69f97be5c
plugin/proxy: remove (#2683)
Point proxy to the fake deprecated plugin, next release that will be
removed as well.

Signed-off-by: Miek Gieben <miek@miek.nl>
2019-03-12 21:36:43 +00:00
David
e45411fdbd modules: cleanup modules support, fix DataDog/dd-trace-go problem (#2680)
cleanup modules support, fix DataDog/dd-trace-go probem, add go.mod tidyness check.
2019-03-12 12:36:13 -04:00
Miek Gieben
b602f3ed06
Remove pkg/healthcheck (#2678)
This now lives on coredns/proxy

Signed-off-by: Miek Gieben <miek@miek.nl>
2019-03-12 12:51:34 +00:00
Miek Gieben
2ffcef1071
Take 3: to get coredns/proxy pulled in (#2677)
* Take 3: to get coredns/proxy pulled in

This is need temporary because it will point to the fake 'deprecated'
plugin anyway.

Signed-off-by: Miek Gieben <miek@miek.nl>

* update proxy again

Signed-off-by: Miek Gieben <miek@miek.nl>
2019-03-12 11:31:46 +00:00
Miek Gieben
91d6451684
plugin/trace: update datadog import (#2676)
Use gopkg.in/DataDog/dd-trace-go.v0 as this is the new home for it

Fixes: #2282

Signed-off-by: Miek Gieben <miek@miek.nl>
2019-03-12 11:01:47 +00:00
Yong Tang
162c3dd95d Remove proxy from kubernetes file (#2668)
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2019-03-11 19:47:29 +00:00
Miek Gieben
b67e4c47c2 Move to miekg/dns 1.1.6 (#2666)
Some more udp/tcp fixes/cleanups have been merged. Run through our gamut
of tests.

Signed-off-by: Miek Gieben <miek@miek.nl>
2019-03-11 09:17:27 -07:00
Miek Gieben
f7d34991c1 miekg/dns to version 1.1.5 (#2662)
This version reverts the worker model that's causes cpu overloads.

Signed-off-by: Miek Gieben <miek@miek.nl>
2019-03-09 10:13:38 -08:00
Miek Gieben
c778b3a67c
plugin/health: remove ability to poll other plugins (#2547)
* plugin/health: remove ability to poll other plugins

This mechanism defeats the purpose any plugin (mostly) caching can still
be alive, we can probably forward queries still. Don't poll plugins,
just tell the world we're up and running.

It was only actually used in kubernetes; and there specifically would
mean any network hiccup would NACK the entire server health.

Fixes: #2534

Signed-off-by: Miek Gieben <miek@miek.nl>

* update docs based on feedback

Signed-off-by: Miek Gieben <miek@miek.nl>
2019-03-07 22:13:47 +00:00
Miek Gieben
db0b16b615
Add *ready* plugin (#2616)
Add a ready plugin that allows plugin to signal when they are ready.
Once a plugin is ready it is not queried again.

This uses same mechanism as the health plugin: each plugin needs to
implement an interface.

Implement readines for the *erratic* plugin to aid in testing.

Add README.md and tests moduled after the health plugin; which will be
relegated to just providing process health. In similar vein to health
this is a process wide setting.

With this Corefile:
~~~
. {
    erratic
    whoami
    ready
}

bla {
    erratic
    whoami
}
~~~

ready will lead to:

~~~ sh
% curl localhost:8181/ready
% dig @localhost -p 1053 mx example.org
% curl localhost:8181/ready
OK%
~~~

Meanwhile CoreDNS logs:

~~~
.:1053
bla.:1053
2019-02-26T20:59:07.137Z [INFO] CoreDNS-1.3.1
2019-02-26T20:59:07.137Z [INFO] linux/amd64, go1.11.4,
CoreDNS-1.3.1
linux/amd64, go1.11.4,
2019-02-26T20:59:11.415Z [INFO] plugin/ready: Still waiting on: "erratic"
2019-02-26T20:59:13.510Z [INFO] plugin/ready: Still waiting on: "erratic"
~~~

*ready* can be used in multiple server blocks and will do the right
thing; query all those plugins from all server blocks for readiness.
This does a similar thing to the prometheus plugin.

Signed-off-by: Miek Gieben <miek@miek.nl>
2019-03-07 20:35:16 +00:00
Miek Gieben
2b7e84a076
Remove internal loop detection (#2647)
* Remove internal loop detection

I can't actually think of a situation where we can create an internal
loop. Sure externally triggered cycles can happen, but this is where the
*loop* plugin comes in that detects those.

Fixes #2602

Signed-off-by: Miek Gieben <miek@miek.nl>

* Remove test

Signed-off-by: Miek Gieben <miek@miek.nl>
2019-03-07 20:23:00 +00:00
Ruslan Drozhdzh
18d305f4b3 plugin/errors: remove cLogger and eLogger (#2657) 2019-03-07 20:14:09 +00:00
Xiao An
89a4b9bd45 Add deprecation notice for NO_RELOAD (#2643)
Signed-off-by: Xiao An <hac@zju.edu.cn>
2019-03-07 20:12:54 +00:00
Francois Tur
97e2a53a65 - remove caddy event, It is now triggered directly by Caddy in the Start function of the Instance (#2656) 2019-03-07 20:05:19 +00:00
Yong Tang
9dd288943a Move *proxy* to external (#2651)
* Move *proxy* to external

move the proxy plugin into coredns/proxy and remove it as a default
plugin. Link the proxy to deprecated in plugin.cfg

coredns/proxy doesn't compile because of the vendoring :(

Signed-off-by: Miek Gieben <miek@miek.nl>

* Add github.com/coredns/proxy

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2019-03-04 07:32:38 +00:00
Yong Tang
dfa413af09 Update README.md to remove the description of vendoring (#2650)
Since we already removed vendor directory.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2019-03-04 07:30:15 +00:00
Yong Tang
5e5c31edfe Update README.md to use go 1.12 (#2649)
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2019-03-04 07:19:50 +00:00
Yong Tang
9d39ea51a7
Add go mod support (#2503)
* Remove vendor and go-dep

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

* Add go.mod

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

* Update Makefile and .travis.yml

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2019-03-03 11:56:26 -08:00
Miek Gieben
39d94835ee
fix typo in notes (#2648)
Copied from https://github.com/coredns/coredns.io/pull/133

Signed-off-by: Miek Gieben <miek@miek.nl>
2019-03-03 19:27:54 +00:00
Yong Tang
b039f5cc67 Update to 1.12.x (#2646)
Automatically submitted.
2019-03-03 14:58:31 +00:00
Miek Gieben
1e9fa297e7 Add release notes into coredns repo (#2645)
* Put release notes in notes subdir

Verbatim copy of the current set of notes on coredns.io. Copy them
here to make them authoritative.

'make sync' on the coredns.io site copies them back in. They need to be
formatted in Hugo style.

Signed-off-by: Miek Gieben <miek@miek.nl>

* pull latest

Signed-off-by: Miek Gieben <miek@miek.nl>
2019-03-03 06:43:09 -08:00
Miek Gieben
8dcc7fccd7
up the version to 1.4.0 (#2642)
Signed-off-by: Miek Gieben <miek@miek.nl>
2019-03-03 10:41:41 +00:00
Miek Gieben
b9fc38a166
make -f Makefile.doc (#2641)
few changes before the 1.4.0 release.

Signed-off-by: Miek Gieben <miek@miek.nl>
2019-03-03 09:35:36 +00:00
Miek Gieben
824367e8e6
plugin/reload: add bug text about import (#2638)
Signed-off-by: Miek Gieben <miek@miek.nl>
2019-03-02 09:03:25 +00:00
Ruslan Drozhdzh
e3e3249016 plugin/forward: check message Id when reading from upstream server (#2637) 2019-03-01 14:40:52 +00:00
JoeWrightss
352a042362 Fix some misspells in comment (#2634)
Signed-off-by: zhoulin xie <zhoulin.xie@daocloud.io>
2019-03-01 10:49:22 +00:00
Miek Gieben
7ffa4f19bb Regen man-pages (#2631)
Mechanical change: make -f Makefile.doc

Signed-off-by: Miek Gieben <miek@miek.nl>
2019-02-27 12:32:48 -08:00
Nguyen Quang Huy
42cf6606fc Fix error string should not be capitalized (#2608)
From [Golang coding convention](https://github.com/golang/go/wiki/CodeReviewComments#error-strings)

Co-Authored-By: Nguyen Van Trung [trungnvfet@outlook.com](mailto:trungnvfet@outlook.com)
Signed-off-by: Nguyen Quang Huy [huynq0911@gmail.com](mailto:huynq0911@gmail.com)
2019-02-27 08:25:02 -05:00
Nguyen Van Duc
c8dbfbdcd8 Add .gitignore files for Eclipse (#2627)
Signed-off-by: vanduc95 <ducnv@vn.fujitsu.com>
2019-02-27 01:07:45 -08:00
tuanvcw
5c46d6c6ef Fix some minor typos (#2625)
Signed-off-by: Vu Cong Tuan <tuanvc@vn.fujitsu.com>
2019-02-27 08:02:50 +00:00
Nguyen Hai Truong
a727747794 Insert *~ when using emacs in .gitignore (#2623)
Ignore temporary files *~ when editting source codes with
emacs.

Co-Authored-By: Dao Cong Tien tiendc@vn.fujitsu.com
Signed-off-by: Nguyen Hai Truong <truongnh@vn.fujitsu.com>
2019-02-27 07:59:54 +00:00
Nguyen Hai Truong
6dfe6b7c61 Ignore DS_Store in file .gitignore (#2622)
Signed-off-by: Nguyen Hai Truong <truongnh@vn.fujitsu.com>
2019-02-26 09:09:38 -08:00
Andrey Meshkov
2b6fb578c3 DoH: Fixing panic in case if there's no response (#2577)
* Fixing panic in case if there's no response

There could be a situation when there's no response after ServeDNS call. With the current implementation, this leads to panic.

* Add comment
2019-02-25 16:16:17 +00:00
Miek Gieben
47cce40d19 Add benchmark test (#2610)
Signed-off-by: Miek Gieben <miek@miek.nl>
2019-02-25 06:57:27 -08:00
LongKB
780a433de8 Update deprecated link in doc (#2607)
Currently, the modified link is out of date. This patch aims to update
this link to the working one that user can access.

Co-Authored-By: Nguyen Phuong An <AnNP@vn.fujitsu.com>
Signed-off-by: Kim Bao Long <longkb@vn.fujitsu.com>
2019-02-24 18:17:52 -08:00
Miek Gieben
78b26c4678 plugin/kubernetes: create dns.Msg later (#2604)
There is no need to do this at the top of the handler, move this
down into the function.

Signed-off-by: Miek Gieben <miek@miek.nl>
2019-02-24 08:04:07 -08:00
Nguyen Hai Truong
a215e4f768 Coredns follows the CNCF Code of Conduct (#2597)
Automatically submitted.
2019-02-24 12:56:13 +00:00
Darshan Chaudhary
70fcbbf6ba refactor tests to remove duplicate code (#2602)
Signed-off-by: darshanime <deathbullet@gmail.com>
2019-02-23 09:02:58 -08:00
JoeWrightss
92b7136684 Fix some typos in comment (#2599)
Signed-off-by: zhoulin xie <zhoulin.xie@daocloud.io>
2019-02-22 09:14:03 -05:00
Yong Tang
8953722327 Restore changes in vendor directory (#2594)
Part of the changes in 2591 modifies the vendor directory
which should not be modified. `dep ensure` will change it back.

This fix reverts the change of
```
vendor/github.com/apache/thrift/lib/go/thrift/simple_json_protocol.go
```

in 2591.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2019-02-22 07:35:05 +00:00
Nguyen Hai Truong
9ce9308f5c Trivial fix typo (#2590)
Although it is spelling mistakes, it might make an affects
while reading.

Signed-off-by: Nguyen Hai Truong <truongnh@vn.fujitsu.com>
2019-02-21 07:23:34 +00:00
LongKB
c8ba2d3ca8 Replacing 'HTTP' by 'HTTPS' for securing links (#2591)
Currently, there are some links that we access with **HTTP**, it is
redirected to **HTTPS** automatically. So this commit aims to
replace **http://...** by **https://...** for security.

Co-Authored-By: Nguyen Phuong An <AnNP@vn.fujitsu.com>
Signed-off-by: Kim Bao Long <longkb@vn.fujitsu.com>
2019-02-21 07:21:25 +00:00
Xiao An
05c0f7161b Fix some typos in documents (#2592)
Signed-off-by: Xiao An <hac@zju.edu.cn>
2019-02-21 07:15:17 +00:00
Miek Gieben
34f17b276a
Fix typo: rrflags -> rflags (#2587)
Signed-off-by: Miek Gieben <miek@miek.nl>
2019-02-21 07:13:05 +00:00