Add CODEOWNERS #13

potyarkin · 2024-12-10T15:33:36Z

potyarkin commented

2024-12-10 15:33:36 +00:00

CODEOWNERS file specifies reviewers which will be automatically added to each PR.

Forgejo uses a bespoke CODEOWNERS parser. It differs from most other tools:

Filepaths are matched using Golang regex library instead of simple fileglobs
All matching lines are active instead of only the first one
There is no support for defining ad-hoc groups, only org teams are supported (@TrueCloudLab/team-name)

This PR is a part of multirepo cleanup effort: TrueCloudLab/frostfs-infra#90

CODEOWNERS file specifies reviewers which will be automatically added to each PR. Forgejo uses a bespoke CODEOWNERS parser. It differs from most other tools: - Filepaths are matched using Golang regex library instead of simple fileglobs - All matching lines are active instead of only the first one - There is no support for defining ad-hoc groups, only org teams are supported (@TrueCloudLab/team-name) This PR is a part of multirepo cleanup effort: https://git.frostfs.info/TrueCloudLab/frostfs-infra/issues/90

potyarkin added 1 commit 2024-12-10 15:33:37 +00:00

[#] Add CODEOWNERS 47f1ff39fb

Signed-off-by: Vitaliy Potyarkin <v.potyarkin@yadro.com>

potyarkin force-pushed feature/add-codeowners from 47f1ff39fb to 8a2b935c08

2024-12-10 15:47:51 +00:00

Compare

potyarkin changed title from ~~WIP: Add CODEOWNERS~~ to Add CODEOWNERS

2024-12-10 15:47:57 +00:00

fyrchik reviewed 2024-12-11 03:30:53 +00:00

CODEOWNERS

					
				@ -0,0 +1,2 @@

				go\\..* @TrueCloudLab/storage-core-developers @TrueCloudLab/storage-core-committers

fyrchik commented

2024-12-11 03:30:53 +00:00

Why not use .* instead of 2 lines?

Why not use `.*` instead of 2 lines?

potyarkin commented

2024-12-11 07:09:09 +00:00

I did not want to ping core team on action.yaml and documentation changes. The idea was to add some other owner for that part but I did not figure out who would that be and left it as is.