Allow to use only PR commits #4
No reviewers
Labels
No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/dco-go#4
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "only-pr-commits"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
As @alexvanin said, we have problems with receiving the list of PR commits in the action. Now we can set it as a target branch and check PR commits only.
We discussed this internally: maybe this code will not work as we expect.
To find PR commits, action looks for a shared commit between master and PR branches. However, this is a master branch of the fork, not the upstream, so it may be quite in the past if fork repo didn't update master branch.
492c74af20
to3dac37bf78
3dac37bf78
to1dcfc18be0
8a8d04ab5c
to7616539e89
It works, see this PR for an example:
TrueCloudLab/frostfs-node#500
LGTM 👍