Allow to use only PR commits #4

Merged

fyrchik merged 1 commit from only-pr-commits into master

2024-09-04 19:51:22 +00:00

fyrchik commented

2023-07-13 08:51:37 +00:00

Owner

As @alexvanin said, we have problems with receiving the list of PR commits in the action. Now we can set it as a target branch and check PR commits only.

fyrchik added 3 commits 2023-07-13 08:51:38 +00:00

Rename PR head variable 102e7d41c0

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

Use merge-base as a starting point 2f1de6fc41

Set it to target branch and check only the commits we are interested in.
If the commit is already in the branch, we just get an old behaviour.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

Use proper error to stop iteration 77aa221efe

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

fyrchik requested review from dstepanov-yadro 2023-07-13 08:52:54 +00:00

fyrchik requested review from alexvanin 2023-07-13 08:52:54 +00:00

fyrchik requested review from dkirillov 2023-07-13 08:52:54 +00:00

fyrchik requested review from pogpp 2023-07-13 08:52:54 +00:00

fyrchik requested review from aarifullin 2023-07-13 08:52:54 +00:00

alexvanin commented

2023-07-18 09:59:49 +00:00

Owner

We discussed this internally: maybe this code will not work as we expect.
To find PR commits, action looks for a shared commit between master and PR branches. However, this is a master branch of the fork, not the upstream, so it may be quite in the past if fork repo didn't update master branch.

We discussed this internally: maybe this code will not work as we expect. To find PR commits, action looks for a shared commit between master and PR branches. However, this is a master branch of the _fork_, not the _upstream_, so it may be quite in the past if fork repo didn't update master branch.

fyrchik force-pushed only-pr-commits from 492c74af20 to 3dac37bf78

2023-08-02 13:55:57 +00:00

Compare

fyrchik force-pushed only-pr-commits from 3dac37bf78 to 1dcfc18be0

2023-08-02 14:00:07 +00:00

Compare

fyrchik force-pushed only-pr-commits from 8a8d04ab5c to 7616539e89

2023-08-02 14:14:49 +00:00

Compare

fyrchik commented

2023-08-02 14:15:35 +00:00

Author