Do not accept commits with no empty string after header #8

elebedeva · 2024-06-26T10:08:55Z

elebedeva commented

2024-06-26 10:08:55 +00:00

Close #7

Signed-off-by: Ekaterina Lebedeva ekaterina.lebedeva@yadro.com

Close #7 Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>

elebedeva requested review from fyrchik 2024-06-26 10:09:25 +00:00

elebedeva requested review from alexvanin 2024-06-26 10:09:25 +00:00

fyrchik requested changes 2024-06-26 10:41:58 +00:00

main.go Outdated

					
				@ -78,2 +86,4 @@

						}

						// Check empty line after header.

						if !rxEmptyLine.MatchString(lines[1]) {

fyrchik commented

2024-06-26 10:41:55 +00:00

Why not lines[1] != ""?

Why not `lines[1] != ""`?

elebedeva commented

2024-06-26 19:29:14 +00:00

I wanted to maintain the general style. Removed.

fyrchik reviewed 2024-06-26 10:44:21 +00:00

main.go Outdated

					
				@ -72,0 +73,4 @@

						// Do not process commits shorter than 3 lines.

						if len(lines) < 3 {

							fail = true

							fmt.Printf("Error: commit is too short [%s]\n", id)

fyrchik commented

2024-06-26 10:43:05 +00:00

It is not an error, commits without long description are valid
(we have signoff, so it will always be >=3 lines, but still, this error is not useful and we have a separate one for signoff

We can use 1 < len(lines) && lines[1] != "" in the condition below to avoid panic.

It is not an error, commits without long description are valid (we have signoff, so it will always be >=3 lines, but still, this error is not useful and we have a separate one for signoff We can use `1 < len(lines) && lines[1] != ""` in the condition below to avoid panic.

elebedeva commented

2024-06-26 19:29:50 +00:00

fixed