[#44] Update executables copy in Dockerfile.local #44

Merged

alexvanin merged 1 commit from fix_issue_creds_copy into master

2024-09-11 12:28:38 +00:00

nzinkevich commented

2024-09-11 09:43:26 +00:00

Member

issue-creds.sh was not copied in Dockerfile.local
Thus make s3cred don't work if image built with make image-aio-local

issue-creds.sh was not copied in Dockerfile.local Thus `make s3cred` don't work if image built with `make image-aio-local`

nzinkevich added 1 commit 2024-09-11 09:43:26 +00:00

[#XXX] Update binaries copy in Dockerfile.local c0e7691ad0

issue-creds.sh was not copied in Dockerfile.local
Thus `make s3cred` don't work
Altered COPY to prevent missing of new binaries

requested reviews from alexvanin, mbiryukova, r.loginov, pogpp

2024-09-11 09:44:54 +00:00

alexvanin requested changes 2024-09-11 12:01:10 +00:00

Dismissed

alexvanin left a comment

Owner

We should update Dockerfile.local but differently.

image-aio-local target is designed to require all binaries in bin folder. If any binary is not present — fail. Therefore we copy it one by one. So, to fix the issue, just add this line from Dockerfile.

To update single binary, use image-aio-custom target.

We should update `Dockerfile.local` but differently. `image-aio-local` target is designed to require all binaries in bin folder. If any binary is not present — fail. Therefore we copy it one by one. So, to fix the issue, just add [this](https://git.frostfs.info/TrueCloudLab/frostfs-aio/src/commit/d83d797cefbc555b705943b1976aaa032a3ee077/Dockerfile#L60) line from Dockerfile. To update single binary, use `image-aio-custom` target.

nzinkevich referenced this pull request from a commit

2024-09-11 12:08:38 +00:00

[#44] Update binaries copy in Dockerfile.local

nzinkevich force-pushed fix_issue_creds_copy from c0e7691ad0 to e1b048c013

2024-09-11 12:08:38 +00:00

Compare

nzinkevich changed title from ~~[#XXX] Update binaries copy in Dockerfile.local~~ to [#44] Update binaries copy in Dockerfile.local

2024-09-11 12:09:34 +00:00

nzinkevich changed title from ~~[#44] Update binaries copy in Dockerfile.local~~ to [#44] Update executables copy in Dockerfile.local

2024-09-11 12:10:10 +00:00

requested review from alexvanin

2024-09-11 12:11:45 +00:00