TrueCloudLab/frostfs-aio
41
0
Fork 8
Code Issues 2 Pull requests 2 Projects Releases Packages 1 Wiki Activity Actions

Add target for building an image from local binaries #17

Merged
alexvanin merged 1 commit from ironbee/frostfs-aio:add_making_local_image_target into master 2023-07-26 21:08:06 +00:00
Conversation 0 Commits 1 Files changed 3 +77 -2
ironbee commented 2023-07-17 14:41:24 +00:00
Contributor
Copy link

Closes #15

Closes #15
ironbee added 1 commit 2023-07-17 14:41:26 +00:00 
Signed-off-by: Artem Tataurov <a.tataurov@yadro.com>
requested reviews from storage-services-committers, storage-services-developers 2023-07-17 14:41:40 +00:00
alexvanin approved these changes 2023-07-18 10:26:56 +00:00
README.md Outdated
@ -104,1 +106,4 @@
## Image with local binaries
Put all the needed pre-built binaries to the `frostfs-aio/bin/`.
alexvanin commented 2023-07-18 10:14:03 +00:00
Owner
Copy link

Please, specify the list of required binaries here.

Please, specify the list of required binaries here.
README.md Outdated
@ -105,0 +107,4 @@
## Image with local binaries
Put all the needed pre-built binaries to the `frostfs-aio/bin/`.
Make sure they have the `x` mode enabled.
alexvanin commented 2023-07-18 10:16:04 +00:00
Owner
Copy link

'x mode' isn't widely used, I think. Consider

Make sure binaries have the right to execute.
'x mode' isn't widely used, I think. Consider ``` Make sure binaries have the right to execute. ```
ironbee force-pushed add_making_local_image_target from ae9ce5f3e7 to c442116c4a 2023-07-18 12:27:27 +00:00 Compare
requested review from alexvanin 2023-07-18 12:52:11 +00:00
alexvanin approved these changes 2023-07-19 07:06:10 +00:00
alexvanin merged commit c442116c4a into master 2023-07-19 07:10:00 +00:00
alexvanin deleted branch add_making_local_image_target 2023-07-19 07:10:04 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-aio#17
No description provided.
Delete branch "ironbee/frostfs-aio:add_making_local_image_target"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?