TrueCloudLab/frostfs-aio
41
0
Fork 8
Code Issues 2 Pull requests 2 Projects Releases Packages 1 Wiki Activity Actions

[#30] Rework logging in the container #39

Merged
alexvanin merged 1 commit from r.loginov/frostfs-aio:feature/30_rework_logging_in_the_container into master 2024-09-03 10:16:02 +00:00
Conversation 0 Commits 1 Files changed 5 +33 -6
r.loginov commented 2024-08-16 06:24:19 +00:00
Member
Copy link

close #30

I have considered several approaches to organizing logs, such as: using tee (current version) with storing logs inside a container, using docker volumes to store logs on a local computer, using logging drivers (syslog, fluentd, local...). Based on the ultimate goals of using frostfs-aio, it seems that the best choice would be a solution with tee. This solution is quite minimalistic and at the same time ensures independence from external tools (not counting those that are used to work with frostfs-aio). Other solutions seem too redundant for this.

close #30 I have considered several approaches to organizing logs, such as: using `tee` (current version) with storing logs inside a container, using docker volumes to store logs on a local computer, using logging drivers (syslog, fluentd, local...). Based on the ultimate goals of using frostfs-aio, it seems that the best choice would be a solution with `tee`. This solution is quite minimalistic and at the same time ensures independence from external tools (not counting those that are used to work with frostfs-aio). Other solutions seem too redundant for this.
r.loginov self-assigned this 2024-08-16 06:24:19 +00:00
r.loginov added 1 commit 2024-08-16 06:24:25 +00:00 
Signed-off-by: Roman Loginov <r.loginov@yadro.com>
r.loginov requested review from storage-services-committers 2024-08-16 06:24:49 +00:00
r.loginov requested review from storage-services-developers 2024-08-16 06:24:49 +00:00
alexvanin requested changes 2024-09-02 14:41:08 +00:00
alexvanin left a comment
Owner
Copy link

Beautiful, I really like this solution. Requires couple minor changes but nothing else.

Beautiful, I really like this solution. Requires couple minor changes but nothing else.
Makefile Outdated
@ -99,0 +103,4 @@
@docker exec aio cat ${LOG_DIR}/$*
# Streaming of the frostFS service logs
stream-logs/%:
alexvanin commented 2024-09-02 14:39:25 +00:00
Owner
Copy link

logs-stream seems better than stream-logs.

If the user doesn't know about this feature, they will write make log and then autocomplete will provide both available targets.

`logs-stream` seems better than `stream-logs`. If the user doesn't know about this feature, they will write `make log` and then autocomplete will provide both available targets.
👍 1
alexvanin marked this conversation as resolved
bin/init-aio.sh Outdated
@ -15,3 +15,3 @@
stage "Starting the blockchain"
/usr/bin/neo-go node --config-path /config --privnet &
/usr/bin/neo-go node --config-path /config --privnet |& tee -a ${LOG_DIR}/neo-go &
alexvanin commented 2024-09-02 14:40:31 +00:00
Owner
Copy link

Please bump patch version of AIO in the .env file. We need to rebuild image that contains these changes.

Please bump patch version of AIO in the `.env` file. We need to rebuild image that contains these changes.
r.loginov commented 2024-09-03 08:06:49 +00:00
Author
Member
Copy link

Do I understand correctly that the aio version needs to be rolled out 1.5.0 -> 1.5.1? If the answer is yes, then maybe it's worth correcting the version target in this case? Otherwise, at the moment, her conclusion may be a little misleading.

$ make version 
89ecc28
frostfs-node: 1.5.1
neo-go:

Firstly, it seems that the frostfs version is node 1.5.0, although this is the aio version. Secondly, neo-go does not display a version at all. It may be worth displaying either only the aio version or also the versions of all components.

Do I understand correctly that the aio `version` needs to be rolled out 1.5.0 -> 1.5.1? If the answer is yes, then maybe it's worth correcting the version target in this case? Otherwise, at the moment, her conclusion may be a little misleading. ```bash $ make version 89ecc28 frostfs-node: 1.5.1 neo-go: ``` Firstly, it seems that the frostfs version is node 1.5.0, although this is the aio version. Secondly, neo-go does not display a version at all. It may be worth displaying either only the aio version or also the versions of all components.
alexvanin commented 2024-09-03 08:12:21 +00:00
Owner
Copy link

Do I understand correctly that the aio version needs to be rolled out 1.5.0 -> 1.5.1?

Yes.

then maybe it's worth correcting the version target in this case?

Let's try to fix it. If it is possible to use .env variables here, let's do it (avoid git describe because we don't add tags in this repo, at least now). If there are any issues with that, just make an issue.

> Do I understand correctly that the aio version needs to be rolled out 1.5.0 -> 1.5.1? Yes. > then maybe it's worth correcting the version target in this case? Let's try to fix it. If it is possible to use `.env` variables here, let's do it (avoid `git describe` because we don't add tags in this repo, at least now). If there are any issues with that, just make an issue.
alexvanin commented 2024-09-03 08:27:55 +00:00
Owner
Copy link

Actually make an issue straight away. We define version components in docker files directly right now, we need to rework it.

Actually make an issue straight away. We define version components in docker files directly right now, we need to rework it.
👍 1
r.loginov commented 2024-09-03 08:47:20 +00:00
Author
Member
Copy link

Issue - #40

Issue - https://git.frostfs.info/TrueCloudLab/frostfs-aio/issues/40
alexvanin marked this conversation as resolved
r.loginov force-pushed feature/30_rework_logging_in_the_container from bb57a99b06 to 89ecc28f2e 2024-09-03 08:32:51 +00:00 Compare
dkirillov approved these changes 2024-09-03 09:24:19 +00:00
alexvanin approved these changes 2024-09-03 10:15:56 +00:00
alexvanin merged commit 89ecc28f2e into master 2024-09-03 10:16:02 +00:00
alexvanin deleted branch feature/30_rework_logging_in_the_container 2024-09-03 10:16:08 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
r.loginov
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-aio#39
No description provided.
Delete branch "r.loginov/frostfs-aio:feature/30_rework_logging_in_the_container"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?