TrueCloudLab/frostfs-aio
41
0
Fork 8
Code Issues 2 Pull requests 2 Projects Releases Packages 1 Wiki Activity Actions

[#40] Move component versions to .env #50

Merged
alexvanin merged 2 commits from nzinkevich/frostfs-aio:fix_versions into master 2024-11-20 15:44:02 +00:00
Conversation 0 Commits 2 Files changed 4 +31 -12
nzinkevich commented 2024-10-17 07:15:09 +00:00
Member
Copy link

Signed-off-by: Nikita Zinkevich n.zinkevich@yadro.com

Signed-off-by: Nikita Zinkevich <n.zinkevich@yadro.com>
nzinkevich self-assigned this 2024-10-17 07:15:09 +00:00
nzinkevich added 1 commit 2024-10-17 07:15:10 +00:00 
Signed-off-by: Nikita Zinkevich <n.zinkevich@yadro.com>
nzinkevich requested review from storage-services-committers 2024-10-17 07:15:22 +00:00
nzinkevich requested review from storage-services-developers 2024-10-17 07:15:22 +00:00
nzinkevich force-pushed fix_versions from bbe0bb4b47 to 5b3f45e11c 2024-10-17 11:45:50 +00:00 Compare
dkirillov reviewed 2024-10-17 14:10:55 +00:00
Makefile Outdated
@ -117,3 +129,3 @@
version:
@echo $(VERSION)
@echo "aio:" $(VERSION)
@echo "frostfs-node: $(AIO_VERSION)"
dkirillov commented 2024-10-17 14:10:55 +00:00
Member
Copy link

I supposes we should drop this line. Or use FROSTFS_CORE_TAG here and drop 132 line

I supposes we should drop this line. Or use `FROSTFS_CORE_TAG` here and drop 132 line
dkirillov marked this conversation as resolved
nzinkevich force-pushed fix_versions from 5b3f45e11c to 563f15fa30 2024-10-18 12:04:26 +00:00 Compare
dkirillov approved these changes 2024-10-18 14:40:14 +00:00
Dismissed
dkirillov left a comment
Member
Copy link

LGTM

LGTM
r.loginov approved these changes 2024-10-22 08:20:45 +00:00
Dismissed
alexvanin reviewed 2024-11-08 10:31:26 +00:00
Dockerfile Outdated
@ -8,0 +4,4 @@
ARG FROSTFS_CORE_TAG
ARG FROSTFS_HTTP_GATE_TAG
ARG FROSTFS_S3_GATE_TAG
ARG NEOGO_TAG
alexvanin commented 2024-11-08 10:31:26 +00:00
Owner
Copy link

Having empty ARG produces warning during build

WARN: InvalidDefaultArgInFrom: Default value for ARG ${NEOGO_HUB_IMAGE}:${NEOGO_TAG} results in empty or invalid base image name (line 9)                       
WARN: InvalidDefaultArgInFrom: Default value for ARG ${FROSTFS_HUB_IMAGE}-adm:${FROSTFS_CORE_TAG} results in empty or invalid base image name (line 10)         
WARN: InvalidDefaultArgInFrom: Default value for ARG ${FROSTFS_HUB_IMAGE}-cli:${FROSTFS_CORE_TAG} results in empty or invalid base image name (line 11)         
WARN: InvalidDefaultArgInFrom: Default value for ARG ${FROSTFS_HUB_IMAGE}-ir:${FROSTFS_CORE_TAG} results in empty or invalid base image name (line 12)          
WARN: InvalidDefaultArgInFrom: Default value for ARG ${FROSTFS_HUB_IMAGE}-storage:${FROSTFS_CORE_TAG} results in empty or invalid base image name (line 13)     
WARN: InvalidDefaultArgInFrom: Default value for ARG ${FROSTFS_HUB_IMAGE}-s3-gw:${FROSTFS_S3_GATE_TAG} results in empty or invalid base image name (line 14)    
WARN: InvalidDefaultArgInFrom: Default value for ARG ${FROSTFS_HUB_IMAGE}-http-gw:${FROSTFS_HTTP_GATE_TAG} results in empty or invalid base image name (line 15)

Let's set some default value, for instance

ARG FROSTFS_CORE_TAG=dev
Having empty ARG produces warning during build ``` WARN: InvalidDefaultArgInFrom: Default value for ARG ${NEOGO_HUB_IMAGE}:${NEOGO_TAG} results in empty or invalid base image name (line 9) WARN: InvalidDefaultArgInFrom: Default value for ARG ${FROSTFS_HUB_IMAGE}-adm:${FROSTFS_CORE_TAG} results in empty or invalid base image name (line 10) WARN: InvalidDefaultArgInFrom: Default value for ARG ${FROSTFS_HUB_IMAGE}-cli:${FROSTFS_CORE_TAG} results in empty or invalid base image name (line 11) WARN: InvalidDefaultArgInFrom: Default value for ARG ${FROSTFS_HUB_IMAGE}-ir:${FROSTFS_CORE_TAG} results in empty or invalid base image name (line 12) WARN: InvalidDefaultArgInFrom: Default value for ARG ${FROSTFS_HUB_IMAGE}-storage:${FROSTFS_CORE_TAG} results in empty or invalid base image name (line 13) WARN: InvalidDefaultArgInFrom: Default value for ARG ${FROSTFS_HUB_IMAGE}-s3-gw:${FROSTFS_S3_GATE_TAG} results in empty or invalid base image name (line 14) WARN: InvalidDefaultArgInFrom: Default value for ARG ${FROSTFS_HUB_IMAGE}-http-gw:${FROSTFS_HTTP_GATE_TAG} results in empty or invalid base image name (line 15) ``` Let's set _some_ default value, for instance ``` ARG FROSTFS_CORE_TAG=dev ```
alexvanin marked this conversation as resolved
nzinkevich force-pushed fix_versions from 563f15fa30 to cce7c6245b 2024-11-08 12:07:09 +00:00 Compare
nzinkevich dismissed dkirillov's review 2024-11-08 12:07:09 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

nzinkevich dismissed r.loginov's review 2024-11-08 12:07:09 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

nzinkevich force-pushed fix_versions from cce7c6245b to cac77b7c5e 2024-11-08 12:08:05 +00:00 Compare
fyrchik reviewed 2024-11-08 14:03:15 +00:00
Dockerfile
@ -5,3 +4,1 @@
ARG FROSTFS_HTTP_GATE_TAG=0.30.2
ARG FROSTFS_S3_GATE_TAG=0.30.7
ARG NEOGO_TAG=0.106.0
ARG FROSTFS_CORE_TAG=dev
fyrchik commented 2024-11-08 14:03:06 +00:00
Owner
Copy link

Does dev have any meaning, or is it just a random string?

Does `dev` have any meaning, or is it just a random string?
alexvanin commented 2024-11-08 14:10:03 +00:00
Owner
Copy link

Random string to avoid warnings during make command.

Random string to avoid warnings during make command.
alexvanin approved these changes 2024-11-08 14:10:40 +00:00
alexvanin merged commit cac77b7c5e into master 2024-11-08 14:11:04 +00:00
alexvanin deleted branch fix_versions 2024-11-08 14:11:06 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
Labels
Clear labels   
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
nzinkevich
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-aio#50
No description provided.
Delete branch "nzinkevich/frostfs-aio:fix_versions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?