TrueCloudLab/frostfs-aio
41
0
Fork 8
Code Issues 2 Pull requests 1 Projects Releases Packages 1 Wiki Activity

[#48] Add S3 Lifecycler #51

Merged
alexvanin merged 1 commit from pogpp/frostfs-aio-pogpp:feature/48_add_lifecycler into nightly-v1.7 2024-11-08 14:09:25 +00:00
Conversation 1 Commits 1 Files changed 6 +74
pogpp commented 2024-11-05 11:27:26 +00:00
Member
Copy link

close #48
Signed-off-by: Pavel Pogodaev p.pogodaev@yadro.com

close #48 Signed-off-by: Pavel Pogodaev <p.pogodaev@yadro.com>
pogpp added 1 commit 2024-11-05 11:27:26 +00:00 
Signed-off-by: Pavel Pogodaev <p.pogodaev@yadro.com>
pogpp requested review from alexvanin 2024-11-05 11:27:53 +00:00
pogpp requested review from dkirillov 2024-11-05 11:27:53 +00:00
pogpp requested review from mbiryukova 2024-11-05 11:27:53 +00:00
pogpp requested review from nzinkevich 2024-11-05 11:27:54 +00:00
nzinkevich approved these changes 2024-11-07 13:57:00 +00:00
Dismissed
alexvanin commented 2024-11-07 14:49:38 +00:00
Owner
Copy link

@pogpp please, change PR target to nightly-v1.7 branch.

@pogpp please, change PR target to `nightly-v1.7` branch.
alexvanin reviewed 2024-11-07 14:55:44 +00:00
s3-lifecycler/lc-user-wallet.json Outdated
@ -0,0 +1,30 @@
{
alexvanin commented 2024-11-07 14:51:32 +00:00
Owner
Copy link

Is this a wallet of data-user or wallet of the service? I think this is a wallet of the service, maybe it's better to name it just lc-wallet.json

Is this a wallet of data-user or wallet of the service? I think this is a wallet of the service, maybe it's better to name it just `lc-wallet.json`
👍 1
s3-lifecycler/s3-lc-config.yaml Outdated
@ -0,0 +28,4 @@
use: wallets
source:
wallets:
- path: /config/lc-user-wallet.json
alexvanin commented 2024-11-07 14:54:33 +00:00
Owner
Copy link

I don't think we need lc-wallet.json here. We have plenty of user wallets.
I suggest you to add a few:

  • /config/user-wallet.json DONE
  • /wallets/wallet1.json
  • /wallets/wallet2.json
  • /wallets/wallet3.json

This should be enough for most test cases. All of them have empty passwords. They are located in wallets dir in repo.

I don't think we need `lc-wallet.json` here. We have plenty of user wallets. I suggest you to add a few: - /config/user-wallet.json **DONE** - /wallets/wallet1.json - /wallets/wallet2.json - /wallets/wallet3.json This should be enough for most test cases. All of them have empty passwords. They are located in wallets dir in repo.
👍 1
alexvanin commented 2024-11-08 10:33:45 +00:00
Owner
Copy link

You've added wallet1.json but not wallet2.json and wallet3.json. Why?

You've added wallet1.json but not wallet2.json and wallet3.json. Why?
pogpp force-pushed feature/48_add_lifecycler from 9031da1b60 to 59968bf8ba 2024-11-08 09:50:00 +00:00 Compare
pogpp dismissed nzinkevich's review 2024-11-08 09:50:00 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

dkirillov reviewed 2024-11-08 10:26:28 +00:00
s3-lifecycler/s3-lc-config.yaml Outdated
@ -0,0 +4,4 @@
address: NhCHDEtGgSph1v6PmjFC1gtzJWNKtNSadk # Account address. If omitted default one will be used.
passphrase: "" # Passphrase to decrypt wallet. If you're using a wallet without a password, place '' here.
logger:
dkirillov commented 2024-11-08 10:26:28 +00:00
Member
Copy link

Should we also enable tags?

Should we also enable tags?
alexvanin commented 2024-11-08 10:32:27 +00:00
Owner
Copy link

I would rather see how it goes first, and then enable some tags by default later.

I would rather see how it goes first, and then enable some tags by default later.
👍 1
dkirillov marked this conversation as resolved
dkirillov approved these changes 2024-11-08 10:34:46 +00:00
Dismissed
dkirillov left a comment
Member
Copy link

LGTM

LGTM
pogpp force-pushed feature/48_add_lifecycler from 59968bf8ba to 13159fd7af 2024-11-08 11:51:36 +00:00 Compare
pogpp dismissed dkirillov's review 2024-11-08 11:51:37 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

pogpp changed target branch from master to nightly-v1.7 2024-11-08 11:52:15 +00:00
pogpp force-pushed feature/48_add_lifecycler from 13159fd7af to b30dc2ae02 2024-11-08 11:54:10 +00:00 Compare
alexvanin approved these changes 2024-11-08 14:09:19 +00:00
alexvanin merged commit b30dc2ae02 into nightly-v1.7 2024-11-08 14:09:25 +00:00
alexvanin deleted branch feature/48_add_lifecycler 2024-11-08 14:09:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
mbiryukova
alexvanin
Labels
Clear labels   
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-aio#51
No description provided.
Delete branch "pogpp/frostfs-aio-pogpp:feature/48_add_lifecycler"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?