WIP: [SUPPORT] Make rpc client stream initialization get cancelled by dial timeout #128

Closed

aarifullin wants to merge 1 commit from aarifullin/frostfs-api-go:fix/client_rpc into support/v2.17

aarifullin commented

2024-12-13 12:39:45 +00:00

Member

c.conn may be already invalidated but the rpc client can't detect this. NewStream may hang trying to open a stream with invalidated connection. Using timer with dialTimeout for NewStream fixes this problem.

* `c.conn` may be already invalidated but the rpc client can't detect this. `NewStream` may hang trying to open a stream with invalidated connection. Using timer with `dialTimeout` for `NewStream` fixes this problem.

aarifullin added the

bug

label 2024-12-13 12:39:45 +00:00

aarifullin added 1 commit 2024-12-13 12:39:46 +00:00

[#301 ] rpc: Make client stream initialization get cancelled by dial timeout

Tests and linters / Lint (pull_request) Successful in 2m13s

Details

DCO action / DCO (pull_request) Successful in 4m40s

Details

Tests and linters / Tests (pull_request) Successful in 4m59s

Details

Tests and linters / Tests with -race (pull_request) Successful in 5m21s

Details

8ea650ac76

* `c.conn` may be already invalidated but the rpc client can't detect this.
  `NewStream` may hang trying to open a stream with invalidated connection.
   Using timer with `dialTimeout` for `NewStream` fixes this problem.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>

requested reviews from storage-core-committers, storage-core-developers, storage-services-committers, storage-services-developers

2024-12-13 12:39:46 +00:00

aarifullin force-pushed fix/client_rpc from 8ea650ac76 to cdf6f3381c

2024-12-13 12:40:16 +00:00

Compare

acid-ant approved these changes 2024-12-13 12:43:23 +00:00

a-savchuk approved these changes 2024-12-13 13:00:33 +00:00

aarifullin changed title from ~~[SUPPORT] Make rpc client stream initialization get cancelled by dial timeout~~ to WIP: [SUPPORT] Make rpc client stream initialization get cancelled by dial timeout

2024-12-13 13:25:23 +00:00