TrueCloudLab/frostfs-api-go
22
0
Fork 16
Code Issues 10 Pull requests 2 Projects Releases Activity Actions

WIP: [SUPPORT] Make rpc client stream initialization get cancelled by dial timeout #128

Draft
aarifullin wants to merge 1 commit from aarifullin/frostfs-api-go:fix/client_rpc into support/v2.17
pull from: aarifullin/frostfs-api-go:fix/client_rpc
merge into: TrueCloudLab:support/v2.17
Conversation 0 Commits 1 Files changed 1 +47 -8
aarifullin commented 2024-12-13 12:39:45 +00:00
Member
Copy link
  • c.conn may be already invalidated but the rpc client can't detect this. NewStream may hang trying to open a stream with invalidated connection. Using timer with dialTimeout for NewStream fixes this problem.
* `c.conn` may be already invalidated but the rpc client can't detect this. `NewStream` may hang trying to open a stream with invalidated connection. Using timer with `dialTimeout` for `NewStream` fixes this problem.
aarifullin added the
bug
 label 2024-12-13 12:39:45 +00:00
aarifullin added 1 commit 2024-12-13 12:39:46 +00:00
[#301] rpc: Make client stream initialization get cancelled by dial timeout
All checks were successful
Tests and linters / Lint (pull_request) Successful in 2m13s
Details
DCO action / DCO (pull_request) Successful in 4m40s
Details
Tests and linters / Tests (pull_request) Successful in 4m59s
Details
Tests and linters / Tests with -race (pull_request) Successful in 5m21s
Details
8ea650ac76 
* `c.conn` may be already invalidated but the rpc client can't detect this.
  `NewStream` may hang trying to open a stream with invalidated connection.
   Using timer with `dialTimeout` for `NewStream` fixes this problem.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
aarifullin requested review from storage-core-committers 2024-12-13 12:39:46 +00:00
aarifullin requested review from storage-core-developers 2024-12-13 12:39:46 +00:00
aarifullin requested review from storage-services-committers 2024-12-13 12:39:46 +00:00
aarifullin requested review from storage-services-developers 2024-12-13 12:39:46 +00:00
aarifullin force-pushed fix/client_rpc from 8ea650ac76 to cdf6f3381c 2024-12-13 12:40:16 +00:00 Compare
acid-ant approved these changes 2024-12-13 12:43:23 +00:00
a-savchuk approved these changes 2024-12-13 13:00:33 +00:00
aarifullin changed title from [SUPPORT] Make rpc client stream initialization get cancelled by dial timeout to WIP: [SUPPORT] Make rpc client stream initialization get cancelled by dial timeout 2024-12-13 13:25:23 +00:00
All checks were successful
Tests and linters / Lint (pull_request) Successful in 1m58s
Details
DCO action / DCO (pull_request) Successful in 4m18s
Details
Tests and linters / Tests (pull_request) Successful in 4m52s
Details
Tests and linters / Tests with -race (pull_request) Successful in 4m54s
Details
This pull request is marked as a work in progress.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u fix/client_rpc:aarifullin-fix/client_rpc
git checkout aarifullin-fix/client_rpc
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
a-savchuk
TrueCloudLab/storage-services-committers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api-go#128
No description provided.
Delete branch "aarifullin/frostfs-api-go:fix/client_rpc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?