TrueCloudLab/frostfs-api-go
21
0
Fork 16
Code Issues 10 Pull requests 1 Projects Releases Activity Actions

tracing: Fix panic on closed channel #24

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-api-go:fix/tracing-panic into master 2023-04-18 08:08:23 +00:00
Conversation 1 Commits 1 Files changed 1 -1
dstepanov-yadro commented 2023-04-18 07:47:27 +00:00
Member
Copy link

Related TrueCloudLab/frostfs-node#263

Closed channel is also ready for communication, so select statement can write to it.

Related https://git.frostfs.info/TrueCloudLab/frostfs-node/issues/263 Closed channel is also ready for communication, so select statement can write to it.
dstepanov-yadro force-pushed fix/tracing-panic from e5dd1004a1 to 30c5a0f55c 2023-04-18 07:48:21 +00:00 Compare
dstepanov-yadro requested review from storage-core-committers 2023-04-18 07:48:40 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-04-18 07:48:40 +00:00
fyrchik reviewed 2023-04-18 07:50:48 +00:00
pkg/tracing/grpc.go
@ -51,7 +51,6 @@ func NewGRPCStreamClientInterceptor() grpc.StreamClientInterceptor {
strWrp := newgRPCClientStream(str, desc, finished, done)
go func() {
defer close(finished)
fyrchik commented 2023-04-18 07:50:45 +00:00
Owner
Copy link

Who will close it then?

Who will close it then?
dstepanov-yadro commented 2023-04-18 08:01:00 +00:00
Author
Member
Copy link

No one will close this channel. After goroutine closes done channel no one can write to finished. After GC collects stream, it will be no readers and no writers. It's ok to leave channel open: https://groups.google.com/g/golang-nuts/c/pZwdYRGxCIk/m/qpbHxRRPJdUJ

No one will close this channel. After goroutine closes `done` channel no one can write to `finished`. After GC collects stream, it will be no readers and no writers. It's ok to leave channel open: https://groups.google.com/g/golang-nuts/c/pZwdYRGxCIk/m/qpbHxRRPJdUJ
fyrchik marked this conversation as resolved
fyrchik merged commit bd44a3f47b into master 2023-04-18 08:08:23 +00:00
fyrchik commented 2023-04-18 08:09:18 +00:00
Owner
Copy link

Sorry, pressed merge button mechanically without enough approvals.

Sorry, pressed merge button mechanically without enough approvals.
Sign in to join this conversation.
Reviewers
No reviewers
TrueCloudLab/storage-core-committers
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api-go#24
No description provided.
Delete branch "dstepanov-yadro/frostfs-api-go:fix/tracing-panic"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?