TrueCloudLab
/
frostfs-api-go
21
0
Fork 11
Code Issues 8 Pull Requests 2 Actions Releases Activity

tracing: Fix panic on closed channel #24

Merged
fyrchik merged 1 commits from dstepanov-yadro/frostfs-api-go:fix/tracing-panic into master 2023-04-18 08:08:23 +00:00
Conversation 1 Commits 1 Files Changed 1
dstepanov-yadro commented 2023-04-18 07:47:27 +00:00
Collaborator

Related TrueCloudLab/frostfs-node#263

Closed channel is also ready for communication, so select statement can write to it.

Related https://git.frostfs.info/TrueCloudLab/frostfs-node/issues/263 Closed channel is also ready for communication, so select statement can write to it.
dstepanov-yadro force-pushed fix/tracing-panic from e5dd1004a1 to 30c5a0f55c 2023-04-18 07:48:21 +00:00 Compare
dstepanov-yadro requested review from storage-core-committers 2023-04-18 07:48:40 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-04-18 07:48:40 +00:00
fyrchik reviewed 2023-04-18 07:50:48 +00:00
pkg/tracing/grpc.go
@ -51,7 +51,6 @@ func NewGRPCStreamClientInterceptor() grpc.StreamClientInterceptor {
strWrp := newgRPCClientStream(str, desc, finished, done)
go func() {
defer close(finished)
fyrchik commented 2023-04-18 07:50:45 +00:00
Owner

Who will close it then?

Who will close it then?
dstepanov-yadro commented 2023-04-18 08:01:00 +00:00
Poster
Collaborator

No one will close this channel. After goroutine closes done channel no one can write to finished. After GC collects stream, it will be no readers and no writers. It's ok to leave channel open: https://groups.google.com/g/golang-nuts/c/pZwdYRGxCIk/m/qpbHxRRPJdUJ

No one will close this channel. After goroutine closes `done` channel no one can write to `finished`. After GC collects stream, it will be no readers and no writers. It's ok to leave channel open: https://groups.google.com/g/golang-nuts/c/pZwdYRGxCIk/m/qpbHxRRPJdUJ
fyrchik marked this conversation as resolved
fyrchik merged commit bd44a3f47b into master 2023-04-18 08:08:23 +00:00
fyrchik commented 2023-04-18 08:09:18 +00:00
Owner

Sorry, pressed merge button mechanically without enough approvals.

Sorry, pressed merge button mechanically without enough approvals.
Sign in to join this conversation.
Reviewers
No reviewers
TrueCloudLab/storage-core-committers
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api-go#24
There is no content yet.
Delete Branch "dstepanov-yadro/frostfs-api-go:fix/tracing-panic"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?