TrueCloudLab
/
frostfs-api-go
21
0
Fork 12
Code Issues 8 Pull Requests 2 Actions Projects Releases Activity

WIP: [#40] types: Generate StableMarshaler/StableSize methods for protobufs #46

Closed
aarifullin wants to merge 1 commits from aarifullin:feature/40-autogen_marsh/proto-gomod into master
pull from: aarifullin:feature/40-autogen_marsh/proto-gomod
merge into: TrueCloudLab:master
Conversation 0 Commits 1 Files Changed 173
aarifullin commented 2023-07-10 12:31:44 +00:00
Collaborator
  • Add plugin option for protogen in Makefile
  • Fix the generator for the plugin in util/protogen
  • Erase convertable types, move helpful methods to gRPC protobufs
  • Erase helpers for convertations
  • Generate StableMarshlal/StableSize for protobufs by the protoc plugin

Signed-off-by: Airat Arifullin a.arifullin@yadro.com

* Add plugin option for protogen in Makefile * Fix the generator for the plugin in util/protogen * Erase convertable types, move helpful methods to gRPC protobufs * Erase helpers for convertations * Generate StableMarshlal/StableSize for protobufs by the protoc plugin Signed-off-by: Airat Arifullin a.arifullin@yadro.com
aarifullin added 1 commit 2023-07-10 12:31:46 +00:00
Tests and linters / Tests (1.19) (pull_request) Successful in 1m39s Details
Tests and linters / Lint (pull_request) Successful in 1m46s Details
Tests and linters / Tests with -race (pull_request) Successful in 3m12s Details
Tests and linters / Tests (1.20) (pull_request) Successful in 7m6s Details
2511f4ca70 [#40] types: Generate StableMarshaler/StableSize methods for protobufs 
* Add plugin option for protogen in Makefile
* Fix the generator for the plugin in util/protogen
* Erase convertable types, move helpful methods to gRPC protobufs
* Erase helpers for convertations
* Generate StableMarshlal/StableSize for protobufs by the protoc plugin

Signed-off-by: Airat Arifullin a.arifullin@yadro.com
aarifullin changed title from [#40] types: Generate StableMarshaler/StableSize methods for protobufs to WIP: [#40] types: Generate StableMarshaler/StableSize methods for protobufs 2023-07-10 12:31:50 +00:00
aarifullin closed this pull request 2023-07-10 12:53:10 +00:00
aarifullin deleted branch feature/40-autogen_marsh/proto-gomod 2023-07-10 12:53:16 +00:00
All checks were successful
Tests and linters / Tests (1.19) (pull_request) Successful in 1m39s
Details
Tests and linters / Lint (pull_request) Successful in 1m46s
Details
Tests and linters / Tests with -race (pull_request) Successful in 3m12s
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 7m6s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api-go#46
There is no content yet.
Delete Branch "aarifullin:feature/40-autogen_marsh/proto-gomod"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?