TrueCloudLab/frostfs-api-go
20
0
Fork 16
Code Issues 10 Pull requests 1 Projects Releases Activity Actions

Optimize object put #58

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-api-go:feat/put_optimize into master 2024-09-04 19:51:16 +00:00
Conversation 0 Commits 1 Files changed 1 +1 -1
dstepanov-yadro commented 2023-10-06 12:11:09 +00:00
Member
Copy link

Now it is possible to store marshal data for object. If marshaled data has been set, then marshaled data will be returned as StableMarshal result.
I also disabled caching of test results.

Now it is possible to store marshal data for object. If marshaled data has been set, then marshaled data will be returned as `StableMarshal` result. I also disabled caching of test results.
dstepanov-yadro force-pushed feat/put_optimize from e78ccc430d to d0f4cb080a 2023-10-06 12:16:58 +00:00 Compare
dstepanov-yadro force-pushed feat/put_optimize from d0f4cb080a to c0d1d6893a 2023-10-23 13:04:22 +00:00 Compare
dstepanov-yadro requested review from storage-core-committers 2023-10-23 13:04:31 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-10-23 13:04:33 +00:00
dstepanov-yadro force-pushed feat/put_optimize from c0d1d6893a to 72ffd38ab1 2023-10-23 13:32:41 +00:00 Compare
aarifullin reviewed 2023-10-25 15:49:19 +00:00
object/types.go Outdated
@ -76,2 +76,4 @@
payload []byte
// marshalData holds marshaled data, must not be marshaled by StableMarshal
aarifullin commented 2023-10-25 15:49:19 +00:00
Member
Copy link

Thank you for this comment :) 👍

Thank you for this comment :) 👍
aarifullin approved these changes 2023-10-25 15:49:30 +00:00
acid-ant approved these changes 2023-10-30 12:45:20 +00:00
fyrchik approved these changes 2023-10-31 10:31:54 +00:00
object/marshal.go Outdated
@ -336,6 +344,17 @@ func (o *Object) StableMarshal(buf []byte) []byte {
return buf
}
func (o *Object) SetMarshalData(data []byte) {
fyrchik commented 2023-10-31 10:31:51 +00:00
Owner
Copy link

Do we have some contract with the caller here? Like calling otherSet functions after SetMarshalData is unsafe?

Do we have some contract with the caller here? Like calling other`Set` functions after `SetMarshalData` is unsafe?
dstepanov-yadro commented 2023-10-31 10:48:17 +00:00
Author
Member
Copy link

Like calling otherSet functions after SetMarshalData is unsafe

It is true, so yes, we have.

Added comment.

> Like calling otherSet functions after SetMarshalData is unsafe It is true, so yes, we have. Added comment.
dstepanov-yadro force-pushed feat/put_optimize from 72ffd38ab1 to 498877e378 2023-10-31 10:48:12 +00:00 Compare
aarifullin approved these changes 2023-11-02 09:06:36 +00:00
fyrchik merged commit 498877e378 into master 2023-11-02 14:07:01 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
aarifullin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api-go#58
No description provided.
Delete branch "dstepanov-yadro/frostfs-api-go:feat/put_optimize"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?