Optimize memory allocations #784

dstepanov-yadro · 2023-11-02T14:40:48Z

dstepanov-yadro commented

2023-11-02 14:40:48 +00:00

Relates #531

Add optimization from TrueCloudLab/frostfs-api-go#58

Relates #531 Add optimization from https://git.frostfs.info/TrueCloudLab/frostfs-api-go/pulls/58

dstepanov-yadro added 2 commits 2023-11-02 14:40:54 +00:00

[#531 ] go.mod: Update api-go version 7b1eda5107

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>

[#531 ] signSvc: Add SetMarshaledData method call

Vulncheck / Vulncheck (pull_request) Successful in 1m25s

Details

DCO action / DCO (pull_request) Successful in 1m36s

Details

Build / Build Components (1.21) (pull_request) Successful in 2m40s

Details

Build / Build Components (1.20) (pull_request) Successful in 3m2s

Details

Tests and linters / Tests (1.21) (pull_request) Successful in 5m41s

Details

Tests and linters / Staticcheck (pull_request) Successful in 5m32s

Details

Tests and linters / Lint (pull_request) Successful in 5m59s

Details

Tests and linters / Tests (1.20) (pull_request) Successful in 6m3s

Details

Tests and linters / Tests with -race (pull_request) Successful in 6m6s

Details

20d6132f31

To reduce memory allocations add `SetMarshaledData` method call
to return already marshalled data in next `StableMarshal` calls.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>

fyrchik approved these changes 2023-11-02 14:45:56 +00:00

pkg/services/object/sign.go

					
				@ -122,6 +122,7 @@ func (s *SignService) Head(ctx context.Context, req *object.HeadRequest) (*objec

				}

				func (s *SignService) PutSingle(ctx context.Context, req *object.PutSingleRequest) (*object.PutSingleResponse, error) {

					req.GetBody().SetMarshalData(nil)

fyrchik commented

2023-11-02 14:45:54 +00:00

Why do we need this line?

dstepanov-yadro commented

2023-11-02 14:48:00 +00:00

Here we marshal data and store it in PutSingleRequest, so next StableMarshal calls (for signature verification and save to shard) will use already prepared data.

Here we marshal data and store it in PutSingleRequest, so next `StableMarshal` calls (for signature verification and save to shard) will use already prepared data.