TrueCloudLab/frostfs-api-go
19
0
Fork 15
Code Issues 10 Pull requests Projects Releases Activity Actions

session: Introduce ObjectPatch verb #100

Merged
fyrchik merged 1 commit from aarifullin/frostfs-api-go:feat/patch/session into master 2024-08-06 12:35:02 +00:00
Conversation 0 Commits 1 Files changed 3 +5
aarifullin commented 2024-08-05 17:53:39 +00:00
Member
Copy link

Signed-off-by: Airat Arifullin a.arifullin@yadro.com

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
aarifullin added 1 commit 2024-08-05 17:53:43 +00:00
[#XX] session: Introduce ObjectPatch verb
Some checks failed
DCO action / DCO (pull_request) Failing after 1m23s
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 1m20s
Details
Tests and linters / Tests (1.19) (pull_request) Successful in 1m27s
Details
Tests and linters / Lint (pull_request) Successful in 1m29s
Details
Tests and linters / Tests with -race (pull_request) Successful in 1m41s
Details
3e2668b511 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
aarifullin force-pushed feat/patch/session from 3e2668b511 to a6d5f2864f 2024-08-05 17:53:57 +00:00 Compare
acid-ant approved these changes 2024-08-05 18:49:11 +00:00
dstepanov-yadro approved these changes 2024-08-06 05:40:57 +00:00
fyrchik reviewed 2024-08-06 06:10:12 +00:00
session/types.go Outdated
@ -175,6 +175,7 @@ const (
ObjectVerbDelete
ObjectVerbRange
ObjectVerbRangeHash
ObjectPatch
fyrchik commented 2024-08-06 06:10:12 +00:00
Owner
Copy link

Please, follow the naming scheme of other constants -- ObjectVerbPatch.

Please, follow the naming scheme of other constants -- `ObjectVerbPatch`.
aarifullin commented 2024-08-06 09:32:27 +00:00
Author
Member
Copy link

Oh, right. Fixed!

Oh, right. Fixed!
aarifullin force-pushed feat/patch/session from a6d5f2864f to ebaf78c8fa 2024-08-06 09:31:30 +00:00 Compare
acid-ant approved these changes 2024-08-06 11:42:21 +00:00
fyrchik approved these changes 2024-08-06 12:34:58 +00:00
fyrchik merged commit ebaf78c8fa into master 2024-08-06 12:35:02 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
acid-ant
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api-go#100
No description provided.
Delete branch "aarifullin/frostfs-api-go:feat/patch/session"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?