TrueCloudLab/frostfs-api-go
22
0
Fork 16
Code Issues 10 Pull requests 2 Projects Releases Activity Actions

Remove usage of folder vendor #102

Merged
fyrchik merged 2 commits from acid-ant/frostfs-api-go:bugfix/101-fix-make-protoc into master 2024-09-04 19:51:17 +00:00
Conversation 2 Commits 2 Files changed 3 +6 -8
acid-ant commented 2024-08-08 15:05:46 +00:00
Member
Copy link

Close #101

Fix make test.

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Close #101 Fix make test. Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant added 2 commits 2024-08-08 15:05:49 +00:00 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
[#101] Fix make test
All checks were successful
DCO action / DCO (pull_request) Successful in 42s
Details
Tests and linters / Tests (1.19) (pull_request) Successful in 38s
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 42s
Details
Tests and linters / Tests with -race (pull_request) Successful in 1m7s
Details
Tests and linters / Lint (pull_request) Successful in 1m24s
Details
bd3e5195d4 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant requested review from storage-core-committers 2024-08-08 15:05:58 +00:00
acid-ant requested review from storage-core-developers 2024-08-08 15:05:59 +00:00
achuprov approved these changes 2024-08-08 15:06:51 +00:00
dstepanov-yadro approved these changes 2024-08-08 15:10:44 +00:00
fyrchik reviewed 2024-08-08 16:00:44 +00:00
Makefile Outdated
@ -10,3 +10,3 @@
endif
BIN = bin
BIN = .bin
fyrchik commented 2024-08-08 16:00:44 +00:00
Owner
Copy link

why? Fix make test is not a descriptive commit message.

why? `Fix make test` is not a descriptive commit message.
acid-ant commented 2024-08-09 06:11:58 +00:00
Author
Member
Copy link

In this case, go skip this folder during scanning. Otherwise, it is necessary to exclude it from build.

In this case, `go` skip this folder during scanning. Otherwise, it is necessary to exclude it from build.
fyrchik commented 2024-08-09 06:13:49 +00:00
Owner
Copy link

bin contains binaries, not code, thus its name
in node we have BIN = bin, everything works

`bin` contains binaries, not code, thus its name in node we have `BIN = bin`, everything works
acid-ant commented 2024-08-09 06:29:04 +00:00
Author
Member
Copy link

Got the issue.

Got the issue.
acid-ant commented 2024-08-09 06:36:57 +00:00
Author
Member
Copy link

Fixed, please take a look.

Fixed, please take a look.
fyrchik commented 2024-08-09 06:07:06 +00:00
Owner
Copy link

On this PR

# Protoc generate
⇒ Processing ./.bin/protobuf/protoc-v27.2/include/google/protobuf/compiler/plugin.proto
⇒ Processing ./.bin/protobuf/protoc-v27.2/include/google/protobuf/any.proto
⇒ Processing ./.bin/protobuf/protoc-v27.2/include/google/protobuf/descriptor.proto
⇒ Processing ./.bin/protobuf/protoc-v27.2/include/google/protobuf/wrappers.proto
⇒ Processing ./.bin/protobuf/protoc-v27.2/include/google/protobuf/api.proto
⇒ Processing ./.bin/protobuf/protoc-v27.2/include/google/protobuf/timestamp.proto
⇒ Processing ./.bin/protobuf/protoc-v27.2/include/google/protobuf/empty.proto
⇒ Processing ./.bin/protobuf/protoc-v27.2/include/google/protobuf/field_mask.proto
⇒ Processing ./.bin/protobuf/protoc-v27.2/include/google/protobuf/source_context.proto
⇒ Processing ./.bin/protobuf/protoc-v27.2/include/google/protobuf/cpp_features.proto
protoc-gen-go: unable to determine Go import path for ".bin/protobuf/protoc-v27.2/include/google/protobuf/cpp_features.proto"

Please specify either:
        • a "go_package" option in the .proto source file, or
        • a "M" argument on the command line.

See https://protobuf.dev/reference/go/go-generated#package for more information.
On this PR ``` # Protoc generate ⇒ Processing ./.bin/protobuf/protoc-v27.2/include/google/protobuf/compiler/plugin.proto ⇒ Processing ./.bin/protobuf/protoc-v27.2/include/google/protobuf/any.proto ⇒ Processing ./.bin/protobuf/protoc-v27.2/include/google/protobuf/descriptor.proto ⇒ Processing ./.bin/protobuf/protoc-v27.2/include/google/protobuf/wrappers.proto ⇒ Processing ./.bin/protobuf/protoc-v27.2/include/google/protobuf/api.proto ⇒ Processing ./.bin/protobuf/protoc-v27.2/include/google/protobuf/timestamp.proto ⇒ Processing ./.bin/protobuf/protoc-v27.2/include/google/protobuf/empty.proto ⇒ Processing ./.bin/protobuf/protoc-v27.2/include/google/protobuf/field_mask.proto ⇒ Processing ./.bin/protobuf/protoc-v27.2/include/google/protobuf/source_context.proto ⇒ Processing ./.bin/protobuf/protoc-v27.2/include/google/protobuf/cpp_features.proto protoc-gen-go: unable to determine Go import path for ".bin/protobuf/protoc-v27.2/include/google/protobuf/cpp_features.proto" Please specify either: • a "go_package" option in the .proto source file, or • a "M" argument on the command line. See https://protobuf.dev/reference/go/go-generated#package for more information. ```
acid-ant force-pushed bugfix/101-fix-make-protoc from bd3e5195d4 to a0a9b765f3 2024-08-09 06:35:40 +00:00 Compare
acid-ant commented 2024-08-09 06:40:10 +00:00
Author
Member
Copy link

On this PR

# Protoc generate
...
protoc-gen-go: unable to determine Go import path for ".bin/protobuf/protoc-v27.2/include/google/protobuf/cpp_features.proto"

Please specify either:
        • a "go_package" option in the .proto source file, or
        • a "M" argument on the command line.

See https://protobuf.dev/reference/go/go-generated#package for more information.

That happened because protoc generated *.go files based in include folder. Fixed.

> On this PR > ``` > # Protoc generate > ... > protoc-gen-go: unable to determine Go import path for ".bin/protobuf/protoc-v27.2/include/google/protobuf/cpp_features.proto" > > Please specify either: > • a "go_package" option in the .proto source file, or > • a "M" argument on the command line. > > See https://protobuf.dev/reference/go/go-generated#package for more information. > ``` That happened because `protoc` generated `*.go` files based in `include` folder. Fixed.
fyrchik approved these changes 2024-08-09 06:50:46 +00:00
fyrchik merged commit a0a9b765f3 into master 2024-08-09 06:50:52 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
achuprov
dstepanov-yadro
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api-go#102
No description provided.
Delete branch "acid-ant/frostfs-api-go:bugfix/101-fix-make-protoc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?