TrueCloudLab/frostfs-api-go
22
0
Fork 16
Code Issues 10 Pull requests 2 Projects Releases Activity Actions

Improve stable marshaling tests #103

Merged
fyrchik merged 3 commits from fyrchik/frostfs-api-go:fix-tests into master 2024-09-04 19:51:17 +00:00
Conversation 0 Commits 3 Files changed 4 +141 -804
fyrchik commented 2024-08-09 08:17:38 +00:00
Owner
Copy link

No more code

No more code
fyrchik added 3 commits 2024-08-09 08:17:41 +00:00 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
proto: Test end-to-end scenario
Some checks failed
Tests and linters / Tests (1.19) (pull_request) Successful in 42s
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 45s
Details
Tests and linters / Tests with -race (pull_request) Successful in 1m22s
Details
Tests and linters / Lint (pull_request) Successful in 1m27s
Details
DCO action / DCO (pull_request) Failing after 1m0s
Details
05d327d53f 
Test the generated code, do not write yet another marshaling routine in
tests.

Before:
```
ok      git.frostfs.info/TrueCloudLab/frostfs-api-go/v2/util/proto      0.003s  coverage: 55.6% of statements
```

After:
```
ok      git.frostfs.info/TrueCloudLab/frostfs-api-go/v2/util/proto      0.003s  coverage: 80.0% of statements
```

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik requested review from storage-core-committers 2024-08-09 08:18:02 +00:00
fyrchik requested review from storage-core-developers 2024-08-09 08:18:03 +00:00
fyrchik requested review from storage-services-committers 2024-08-09 08:18:04 +00:00
fyrchik requested review from storage-services-developers 2024-08-09 08:18:12 +00:00
fyrchik force-pushed fix-tests from 05d327d53f to 47a48969b0 2024-08-09 08:20:15 +00:00 Compare
dstepanov-yadro approved these changes 2024-08-09 08:23:14 +00:00
acid-ant approved these changes 2024-08-09 08:49:08 +00:00
aarifullin approved these changes 2024-08-09 09:04:10 +00:00
fyrchik closed this pull request 2024-08-09 10:07:20 +00:00
fyrchik reopened this pull request 2024-08-09 10:07:27 +00:00
fyrchik referenced this pull request from a commit 2024-08-09 10:07:46 +00:00
[#103] protogen: Handle uint32 type
fyrchik merged commit 47a48969b0 into master 2024-08-09 10:07:46 +00:00
fyrchik deleted branch fix-tests 2024-08-09 10:08:11 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
acid-ant
aarifullin
TrueCloudLab/storage-services-committers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api-go#103
No description provided.
Delete branch "fyrchik/frostfs-api-go:fix-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?