TrueCloudLab/frostfs-api-go
22
0
Fork 16
Code Issues 10 Pull requests 2 Projects Releases Activity Actions

Fix protogen empty messages marshaling #108

Merged
fyrchik merged 2 commits from fyrchik/frostfs-api-go:protogen-compat into master 2024-09-04 19:51:17 +00:00
Conversation 1 Commits 2 Files changed 18 +59 -1
fyrchik commented 2024-08-27 07:55:56 +00:00
Owner
Copy link
  1. Add tests for compatibility of already written StableMarshal() functions. This will be useful during the transition period, were we to add any new messages.
  2. Compare with nil, do not use StableSize() invocation.
1. Add tests for compatibility of _already written_ `StableMarshal()` functions. This will be useful during the transition period, were we to add any new messages. 2. Compare with nil, do not use `StableSize()` invocation.
fyrchik added 2 commits 2024-08-27 07:55:59 +00:00 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
protogen: Distinguish between empty and nil messages
Some checks failed
Tests and linters / Tests (1.22) (pull_request) Successful in 1m21s
Details
DCO action / DCO (pull_request) Failing after 1m24s
Details
Tests and linters / Tests (1.23) (pull_request) Successful in 1m37s
Details
Tests and linters / Tests with -race (pull_request) Successful in 1m50s
Details
Tests and linters / Lint (pull_request) Successful in 2m33s
Details
6a1f9272b2 
Refs #59

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik force-pushed protogen-compat from 6a1f9272b2 to 9310d64742 2024-08-27 07:56:17 +00:00 Compare
fyrchik requested review from storage-core-committers 2024-08-27 07:56:19 +00:00
fyrchik requested review from storage-core-developers 2024-08-27 07:56:19 +00:00
fyrchik commented 2024-08-27 08:01:01 +00:00
Author
Owner
Copy link

Caught by @mbiryukova because of the panic in TrueCloudLab/frostfs-sdk-go#260

Caught by @mbiryukova because of the panic in https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/issues/260
fyrchik force-pushed protogen-compat from 9310d64742 to 5fece80b42 2024-08-27 08:02:28 +00:00 Compare
aarifullin approved these changes 2024-08-27 08:06:42 +00:00
fyrchik added the
bug
internal
 labels 2024-08-27 08:14:08 +00:00
acid-ant approved these changes 2024-08-27 08:15:20 +00:00
fyrchik merged commit 5fece80b42 into master 2024-08-27 08:30:30 +00:00
fyrchik deleted branch protogen-compat 2024-08-27 08:30:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
acid-ant
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api-go#108
No description provided.
Delete branch "fyrchik/frostfs-api-go:protogen-compat"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?