Use `range` over `int` after 1.22 upgrade #113

Merged

fyrchik merged 2 commits from elebedeva/frostfs-api-go:feat/range-over-int-go1.22 into master

2024-11-02 14:21:46 +00:00

elebedeva commented

2024-09-04 13:55:05 +00:00

Member

Relates to TrueCloudLab/frostfs-node#1317

Since Go 1.22 a for statement with a range clause is able to iterate through integer values from zero to an upper limit.

Files were changed via gopatch with a script:

@@
var i, e expression
@@
-for i := 0; i <= e - 1; i++ {
+for i := range e {
    ...
}

@@
var i, e expression
@@
-for i := 0; i <= e; i++ {
+for i := range e + 1 {
    ...
}

@@
var i, e expression
@@
-for i := 0; i < e; i++ {
+for i := range e {
    ...
}

Signed-off-by: Ekaterina Lebedeva ekaterina.lebedeva@yadro.com

Relates to TrueCloudLab/frostfs-node#1317 Since Go 1.22 a `for` statement with a `range` clause is able to iterate through integer values from zero to an upper limit. Files were changed via [`gopatch`](https://github.com/uber-go/gopatch) with a script: ``` @@ var i, e expression @@ -for i := 0; i <= e - 1; i++ { +for i := range e { ... } @@ var i, e expression @@ -for i := 0; i <= e; i++ { +for i := range e + 1 { ... } @@ var i, e expression @@ -for i := 0; i < e; i++ { +for i := range e { ... } ``` Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>

elebedeva added the

refactoring

internal

labels 2024-09-04 13:55:05 +00:00

elebedeva added 2 commits 2024-09-04 13:55:09 +00:00

[#113 ] pre-commit: Update golangci-lint to v1.60.3 7d71556eee

Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>

[#113 ] go.mod: Use range over int

DCO action / DCO (pull_request) Successful in 41s

Details

Tests and linters / Lint (pull_request) Successful in 1m11s

Details

Tests and linters / Tests (1.22) (pull_request) Successful in 1m11s

Details

Tests and linters / Tests (1.23) (pull_request) Successful in 1m10s

Details

Tests and linters / Tests with -race (pull_request) Successful in 1m23s

Details

bd588fa2e5

Since Go 1.22 a `for` statement with a `range` clause is able
to iterate through integer values from zero to an upper limit.

gopatch script:
@@
var i, e expression
@@
-for i := 0; i <= e - 1; i++ {
+for i := range e {
    ...
}

@@
var i, e expression
@@
-for i := 0; i <= e; i++ {
+for i := range e + 1 {
    ...
}

@@
var i, e expression
@@
-for i := 0; i < e; i++ {
+for i := range e {
    ...
}

Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>

elebedeva requested review from storage-core-committers 2024-09-04 13:55:30 +00:00

elebedeva requested review from storage-core-developers 2024-09-04 13:55:31 +00:00