TrueCloudLab/frostfs-api-go
22
0
Fork 16
Code Issues 10 Pull requests 2 Projects Releases Activity Actions

Upgrade google.golang.org/grpc version #117

Merged
dstepanov-yadro merged 2 commits from dstepanov-yadro/frostfs-api-go:feat/grpc-upgrade into master 2024-11-02 14:21:46 +00:00
Conversation 1 Commits 2 Files changed 6 +47 -31
dstepanov-yadro commented 2024-09-13 14:22:33 +00:00
Member
Copy link

After upgrade grpc connection is not actually established, so added new CallOption to specify dialer if needed.

After upgrade grpc connection is not actually established, so added new CallOption to specify dialer if needed.
dstepanov-yadro added 2 commits 2024-09-13 14:22:34 +00:00 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
[#9999] rpc: Allow to specify custom gRPC dialer
All checks were successful
DCO action / DCO (pull_request) Successful in 1m10s
Details
Tests and linters / Lint (pull_request) Successful in 1m21s
Details
Tests and linters / Tests (pull_request) Successful in 1m0s
Details
Tests and linters / Tests with -race (pull_request) Successful in 1m23s
Details
084c3f8e92 
After grpc upgrade there is no DialContext call.
So connection is not actually established after created.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro force-pushed feat/grpc-upgrade from 084c3f8e92 to 6a81f3d404 2024-09-13 14:23:22 +00:00 Compare
dstepanov-yadro requested review from storage-core-committers 2024-09-13 14:32:59 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-09-13 14:33:00 +00:00
dstepanov-yadro commented 2024-09-13 14:33:47 +00:00
Author
Member
Copy link

I will add services to the review after core approve.

I will add services to the review after core approve.
acid-ant approved these changes 2024-09-13 14:53:16 +00:00
Dismissed
fyrchik approved these changes 2024-09-13 15:11:25 +00:00
Dismissed
dstepanov-yadro requested review from storage-services-committers 2024-09-13 15:12:54 +00:00
dstepanov-yadro requested review from storage-services-developers 2024-09-13 15:12:55 +00:00
dstepanov-yadro force-pushed feat/grpc-upgrade from 6a81f3d404 to c866fe308e 2024-09-16 06:10:12 +00:00 Compare
dstepanov-yadro dismissed acid-ant's review 2024-09-16 06:10:13 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

dstepanov-yadro dismissed fyrchik's review 2024-09-16 06:10:13 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

dstepanov-yadro reviewed 2024-09-16 06:10:39 +00:00
rpc/client/connect.go Outdated
@ -33,0 +33,4 @@
defer cancel()
if err := dialer(ctx, c.conn); err != nil {
_ = c.conn.Close()
dstepanov-yadro commented 2024-09-16 06:10:38 +00:00
Author
Member
Copy link

Added after review: DialContext closes connection in case of error.

Added after review: DialContext closes connection in case of error.
acid-ant approved these changes 2024-09-16 06:52:48 +00:00
Dismissed
aarifullin approved these changes 2024-09-16 07:57:42 +00:00
Dismissed
alexvanin approved these changes 2024-09-16 08:40:43 +00:00
Dismissed
nzinkevich reviewed 2024-09-16 08:52:22 +00:00
rpc/client/call_options.go Outdated
@ -28,2 +31,4 @@
}
}
// WithContext returns option to specify grpc dialer. If passed, it will be
nzinkevich commented 2024-09-16 08:51:22 +00:00
Member
Copy link

Update function name in comment

Update function name in comment
dstepanov-yadro commented 2024-09-16 09:36:08 +00:00
Author
Member
Copy link

Done

Done
dstepanov-yadro force-pushed feat/grpc-upgrade from c866fe308e to 13fa0da374 2024-09-16 09:36:00 +00:00 Compare
dstepanov-yadro dismissed acid-ant's review 2024-09-16 09:36:00 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

dstepanov-yadro dismissed aarifullin's review 2024-09-16 09:36:00 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

dstepanov-yadro dismissed alexvanin's review 2024-09-16 09:36:00 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

dstepanov-yadro requested review from storage-core-committers 2024-09-16 11:01:43 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-09-16 11:01:44 +00:00
nzinkevich approved these changes 2024-09-16 11:51:27 +00:00
aarifullin approved these changes 2024-09-16 11:57:58 +00:00
dstepanov-yadro merged commit 13fa0da374 into master 2024-09-16 11:58:56 +00:00
dstepanov-yadro deleted branch feat/grpc-upgrade 2024-09-16 11:58:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
nzinkevich
aarifullin
TrueCloudLab/storage-core-committers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api-go#117
No description provided.
Delete branch "dstepanov-yadro/frostfs-api-go:feat/grpc-upgrade"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?