TrueCloudLab/frostfs-api-go
22
0
Fork 16
Code Issues 10 Pull requests 2 Projects Releases Activity Actions

Fix JSON numeric marshaling #120

Merged
fyrchik merged 7 commits from fyrchik/frostfs-api-go:fix-protogen into master 2024-11-02 14:21:46 +00:00
Conversation 1 Commits 7 Files changed 23 +60 -18
fyrchik commented 2024-10-01 11:11:37 +00:00
Owner
Copy link

Follow canonical encoding: emit 64-bit integers as strings, emit enums as strings, parse both strings and numbers
https://protobuf.dev/programming-guides/proto3/#json

Follow canonical encoding: emit 64-bit integers as strings, emit enums as strings, parse both strings and numbers https://protobuf.dev/programming-guides/proto3/#json
fyrchik added 7 commits 2024-10-01 11:11:38 +00:00 
It is failing, thus is skipped.
But implement it now to make it easier to see it failing.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Be compatible with protojson.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
proto/test: Unskip protojson compatibility test
Some checks failed
Tests and linters / Lint (pull_request) Failing after 1m7s
Details
DCO action / DCO (pull_request) Failing after 1m24s
Details
Tests and linters / Tests (pull_request) Successful in 1m25s
Details
Tests and linters / Tests with -race (pull_request) Successful in 1m25s
Details
abe6242606 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik force-pushed fix-protogen from abe6242606 to 920eedda7b 2024-10-01 11:11:48 +00:00 Compare
fyrchik requested review from storage-core-committers 2024-10-01 11:12:22 +00:00
fyrchik requested review from storage-core-developers 2024-10-01 11:12:23 +00:00
dstepanov-yadro approved these changes 2024-10-01 11:16:01 +00:00
Dismissed
fyrchik force-pushed fix-protogen from 920eedda7b to d9a604fbc1 2024-10-01 11:19:00 +00:00 Compare
fyrchik dismissed dstepanov-yadro's review 2024-10-01 11:19:00 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

fyrchik commented 2024-10-01 11:19:07 +00:00
Author
Owner
Copy link

Update: fixed linter warnings

Update: fixed linter warnings
aarifullin approved these changes 2024-10-01 11:21:51 +00:00
fyrchik requested review from storage-core-committers 2024-10-01 11:22:15 +00:00
fyrchik requested review from storage-core-developers 2024-10-01 11:22:15 +00:00
acid-ant approved these changes 2024-10-01 11:32:09 +00:00
achuprov approved these changes 2024-10-01 11:32:45 +00:00
fyrchik merged commit d9a604fbc1 into master 2024-10-01 11:38:12 +00:00
fyrchik referenced this pull request from a commit 2024-10-01 11:38:13 +00:00
[#120] Regenerate proto files
fyrchik deleted branch fix-protogen 2024-10-01 11:38:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
acid-ant
achuprov
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api-go#120
No description provided.
Delete branch "fyrchik/frostfs-api-go:fix-protogen"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?