TrueCloudLab/frostfs-api-go
22
0
Fork 16
Code Issues 10 Pull requests 1 Projects Releases Activity Actions

protogen: Treat bytes field as non-nullable #123

Merged
fyrchik merged 2 commits from fyrchik/frostfs-api-go:fix-optional-bytes into master 2024-11-02 14:21:46 +00:00
Conversation 1 Commits 2 Files changed 15 +283 -61

2 commits

Author SHA1 Message Date
Evgenii Stratonikov
f0fc40e116
[#123] Resolve funlen linter issue
All checks were successful
DCO action / DCO (pull_request) Successful in 55s
Details
Tests and linters / Tests with -race (pull_request) Successful in 1m8s
Details
Tests and linters / Tests (pull_request) Successful in 1m31s
Details
Tests and linters / Lint (pull_request) Successful in 1m58s
Details 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2024-10-11 14:40:54 +03:00
Evgenii Stratonikov
29f2157563
[#123] protogen: Treat bytes field as non-nullable 
In protobuf 3.12 they have added an support for `optional` keyword,
which has made it into the main branch in 3.15.
https://github.com/protocolbuffers/protobuf/blob/main/docs/implementing_proto3_presence.md
https://github.com/protocolbuffers/protobuf/blob/v3.12.0/docs/field_presence.md#presence-in-proto3-apis

This means that without an explicit `optional` keyword field presence
for scalars is not tracked, thus empty string in JSON should be
unmarshaled to a nil byte slice. Relevant decoding code and tests from
protojson:
fb995f184a/internal/impl/message_reflect_field.go (L327)
fb995f184a/encoding/protojson/decode_test.go (L134)
fb995f184a/encoding/protojson/decode_test.go (L156)

We do not support `optional` keyword and the generator will fail if it sees on.
So only implement the default behaviour.

Refs #122

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2024-10-11 14:40:54 +03:00