TrueCloudLab/frostfs-api-go
20
0
Fork 15
Code Issues 10 Pull requests Projects Releases Activity Actions

tracing: Fix panic on closed channel #24

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-api-go:fix/tracing-panic into master 2023-04-18 08:08:23 +00:00
Conversation 1 Commits 1 Files changed 1 -1
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
pkg/tracing/grpc.go
View file

@ -51,7 +51,6 @@ func NewGRPCStreamClientInterceptor() grpc.StreamClientInterceptor {
strWrp := newgRPCClientStream(str, desc, finished, done)
go func() {
defer close(finished)
fyrchik marked this conversation as resolved
fyrchik commented 2023-04-18 07:50:45 +00:00
Review
Copy link

Who will close it then?

Who will close it then?
dstepanov-yadro commented 2023-04-18 08:01:00 +00:00
Review
Copy link

No one will close this channel. After goroutine closes done channel no one can write to finished. After GC collects stream, it will be no readers and no writers. It's ok to leave channel open: https://groups.google.com/g/golang-nuts/c/pZwdYRGxCIk/m/qpbHxRRPJdUJ

No one will close this channel. After goroutine closes `done` channel no one can write to `finished`. After GC collects stream, it will be no readers and no writers. It's ok to leave channel open: https://groups.google.com/g/golang-nuts/c/pZwdYRGxCIk/m/qpbHxRRPJdUJ
defer close(done)
defer span.End()