TrueCloudLab/frostfs-api-go
21
0
Fork 16
Code Issues 10 Pull requests 1 Projects Releases Activity Actions

[#26] netmap: Add NOT and UNIQUE keywords #35

Merged
fyrchik merged 1 commit from aarifullin/frostfs-api-go:master into master 2023-05-31 10:03:27 +00:00
Conversation 1 Commits 1 Files changed 2 +13
2 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

BIN
netmap/grpc/types.pb.go generated
View file

Binary file not shown.

13
netmap/types.go
View file

@ -55,6 +55,7 @@ type Replica struct {
type Operation uint32
type PlacementPolicy struct {
unique bool
replicas []Replica
backupFactor uint32
selectors []Selector
@ -106,6 +107,7 @@ const (
LE
OR
AND
NOT
)
const (
@ -257,6 +259,17 @@ func (r *Replica) SetCount(count uint32) {
r.count = count
}
func (p *PlacementPolicy) GetUnique() bool {
dstepanov-yadro commented 2023-05-24 06:41:15 +00:00
Outdated
Review
Copy link

I suggest adding a nil check. See GetFilters as example.

I suggest adding a nil check. See GetFilters as example.
👍 1
if p != nil {
return p.unique
}
return false
}
func (p *PlacementPolicy) SetUnique(unique bool) {
p.unique = unique
}
func (p *PlacementPolicy) GetFilters() []Filter {
if p != nil {
return p.filters