TrueCloudLab/frostfs-api-go
21
0
Fork 14
Code Issues 10 Pull requests Projects Releases Activity Actions

[#26] netmap: Add NOT and UNIQUE keywords #35

Merged
fyrchik merged 1 commit from aarifullin/frostfs-api-go:master into master 2023-05-31 10:03:27 +00:00
Conversation 1 Commits 1 Files changed 2 +13
aarifullin commented 2023-05-23 15:54:06 +00:00
Member
Copy link
  • Regenerate types.pb.go for netmap grpc

Signed-off-by: Airat Arifullin a.arifullin@yadro.com

* Regenerate types.pb.go for netmap grpc Signed-off-by: Airat Arifullin a.arifullin@yadro.com
aarifullin added the
enhancement
 label 2023-05-23 15:54:06 +00:00
aarifullin force-pushed master from de5253dbb4 to 3500e149a6 2023-05-23 15:56:25 +00:00 Compare
aarifullin requested review from storage-core-developers 2023-05-23 15:57:28 +00:00
aarifullin requested review from storage-core-committers 2023-05-23 15:57:28 +00:00
acid-ant approved these changes 2023-05-24 06:12:23 +00:00
dstepanov-yadro approved these changes 2023-05-24 06:40:01 +00:00
dstepanov-yadro approved these changes 2023-05-24 06:41:25 +00:00
netmap/types.go Outdated
@ -258,2 +259,4 @@
}
func (p *PlacementPolicy) GetUnique() bool {
return p.unique
dstepanov-yadro commented 2023-05-24 06:41:15 +00:00
Member
Copy link

I suggest adding a nil check. See GetFilters as example.

I suggest adding a nil check. See GetFilters as example.
👍 1
aarifullin force-pushed master from 3500e149a6 to 5aa8d51f83 2023-05-24 09:15:25 +00:00 Compare
aarifullin force-pushed master from 5aa8d51f83 to 4ce4783007 2023-05-24 09:16:44 +00:00 Compare
aarifullin requested review from acid-ant 2023-05-24 09:16:55 +00:00
aarifullin requested review from dstepanov-yadro 2023-05-24 09:16:57 +00:00
aarifullin changed title from [#26] netmap: Add NOT and UNIQUE keywords to WIP: [#26] netmap: Add NOT and UNIQUE keywords 2023-05-24 10:18:21 +00:00
aarifullin commented 2023-05-24 10:18:24 +00:00
Author
Member
Copy link

TrueCloudLab/frostfs-sdk-go#78 (comment)

https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/pulls/78#issuecomment-10825
acid-ant approved these changes 2023-05-24 11:33:45 +00:00
aarifullin changed title from WIP: [#26] netmap: Add NOT and UNIQUE keywords to [#26] netmap: Add NOT and UNIQUE keywords 2023-05-24 13:01:01 +00:00
aarifullin requested review from acid-ant 2023-05-24 13:01:04 +00:00
dstepanov-yadro approved these changes 2023-05-24 13:59:53 +00:00
acid-ant approved these changes 2023-05-24 17:29:10 +00:00
aarifullin force-pushed master from 4ce4783007 to 8266b31092 2023-05-31 09:06:38 +00:00 Compare
aarifullin requested review from dstepanov-yadro 2023-05-31 09:07:29 +00:00
aarifullin requested review from acid-ant 2023-05-31 09:07:32 +00:00
dstepanov-yadro approved these changes 2023-05-31 09:08:11 +00:00
acid-ant approved these changes 2023-05-31 09:34:34 +00:00
fyrchik approved these changes 2023-05-31 10:03:18 +00:00
fyrchik merged commit 8266b31092 into master 2023-05-31 10:03:27 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
acid-ant
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api-go#35
No description provided.
Delete branch "aarifullin/frostfs-api-go:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?