TrueCloudLab/frostfs-api-go
19
0
Fork 15
Code Issues 10 Pull requests Projects Releases Activity Actions

Add PutSingle request/response #45

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-api-go:feat/put_single into master 2023-07-26 21:08:03 +00:00
Conversation 3 Commits 1 Files changed 1 +24 -7
dstepanov-yadro commented 2023-06-30 12:02:01 +00:00
Member
Copy link
No description provided.
dstepanov-yadro force-pushed feat/put_single from 0f257ee12b to e56a42d8bd 2023-06-30 12:38:05 +00:00 Compare
fyrchik approved these changes 2023-07-04 05:23:59 +00:00
fyrchik commented 2023-07-04 05:24:22 +00:00
Owner
Copy link

@dstepanov-yadro we still have #9999 in commits.

@dstepanov-yadro we still have #9999 in commits.
fyrchik requested review from storage-core-committers 2023-07-04 05:24:32 +00:00
fyrchik requested review from storage-core-developers 2023-07-04 05:24:33 +00:00
fyrchik commented 2023-07-04 05:24:59 +00:00
Owner
Copy link

Oh, it's still WIP.

Oh, it's still WIP.
dstepanov-yadro force-pushed feat/put_single from 54ed22d061 to 0dd08fab3b 2023-07-04 09:25:09 +00:00 Compare
dstepanov-yadro changed title from WIP: Add PutSingle request/response to Add PutSingle request/response 2023-07-04 09:25:13 +00:00
dstepanov-yadro force-pushed feat/put_single from 0dd08fab3b to 285516a94e 2023-07-04 09:27:50 +00:00 Compare
ale64bit approved these changes 2023-07-04 09:30:12 +00:00
ale64bit left a comment
Member
Copy link

The amount of wrapper code we manually write but should be autogenerating/getting rid of is painful.

The amount of wrapper code we manually write but should be autogenerating/getting rid of is painful.
aarifullin approved these changes 2023-07-04 09:35:17 +00:00
aarifullin left a comment
Member
Copy link

LGTM

LGTM
aarifullin commented 2023-07-04 09:36:01 +00:00
Member
Copy link

The amount of wrapper code we manually write but should be autogenerating/getting rid of is painful.

Welcome :)
#43

> The amount of wrapper code we manually write but should be autogenerating/getting rid of is painful. Welcome :) https://git.frostfs.info/TrueCloudLab/frostfs-api-go/pulls/43
fyrchik approved these changes 2023-07-04 10:41:43 +00:00
fyrchik merged commit 285516a94e into master 2023-07-04 10:41:47 +00:00
fyrchik referenced this pull request from a commit 2023-07-04 10:41:48 +00:00
[#45] api-go: Add PutSingle RPC call
Sign in to join this conversation.
Reviewers
No reviewers
ale64bit
aarifullin
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api-go#45
No description provided.
Delete branch "dstepanov-yadro/frostfs-api-go:feat/put_single"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?