TrueCloudLab/frostfs-api-go
22
0
Fork 16
Code Issues 10 Pull requests 2 Projects Releases Activity Actions

protogen: Do not panic in StableSize() #51

Merged
fyrchik merged 2 commits from fyrchik/frostfs-api-go:fix-stablesize-alloc into master 2024-09-04 19:51:16 +00:00
Conversation 0 Commits 2 Files changed 3 +21
fyrchik commented 2023-08-02 07:47:06 +00:00
Owner
Copy link

Refs TrueCloudLab/frostfs-node#554 .
Introduced in #49.

Signed-off-by: Evgenii Stratonikov e.stratonikov@yadro.com

Refs https://git.frostfs.info/TrueCloudLab/frostfs-node/issues/554 . Introduced in #49. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik force-pushed fix-stablesize-alloc from c7b522ed15 to 3072090c77 2023-08-02 07:47:30 +00:00 Compare
fyrchik changed title from [#xx] protogen: Do not panic in StableSize() to protogen: Do not panic in StableSize() 2023-08-02 07:48:10 +00:00
fyrchik requested review from storage-core-committers 2023-08-02 07:49:19 +00:00
fyrchik requested review from storage-core-developers 2023-08-02 07:49:19 +00:00
dstepanov-yadro approved these changes 2023-08-02 07:49:59 +00:00
acid-ant approved these changes 2023-08-02 07:51:32 +00:00
aarifullin approved these changes 2023-08-02 07:52:23 +00:00
aarifullin approved these changes 2023-08-02 07:52:27 +00:00
fyrchik added 1 commit 2023-08-02 07:55:27 +00:00
[#51] *: Do not panic in StableSize()
All checks were successful
Tests and linters / Lint (pull_request) Successful in 2m0s
Details
Tests and linters / Tests (1.19) (pull_request) Successful in 3m27s
Details
Tests and linters / Tests with -race (pull_request) Successful in 1m44s
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 3m29s
Details
964c3edb3f 
After #49 it can be called on nil structures.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
acid-ant approved these changes 2023-08-02 07:57:20 +00:00
fyrchik merged commit 964c3edb3f into master 2023-08-02 08:02:43 +00:00
fyrchik deleted branch fix-stablesize-alloc 2023-08-02 08:02:44 +00:00
fyrchik referenced this pull request from a commit 2023-08-02 08:02:45 +00:00
[#51] *: Do not panic in StableSize()
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
aarifullin
acid-ant
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api-go#51
No description provided.
Delete branch "fyrchik/frostfs-api-go:fix-stablesize-alloc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?