TrueCloudLab
/
frostfs-api-go
23
0
Fork 12
Code Issues 8 Pull Requests 2 Actions Releases Activity

[#50] util: Use protowire for util/proto helpers #52

Merged
fyrchik merged 1 commits from aarifullin/frostfs-api-go:feature/50-use_protowire into master 2023-08-10 16:40:55 +00:00
Conversation 0 Commits 1 Files Changed 2
aarifullin commented 2023-08-02 13:55:44 +00:00
Collaborator
  • Use methods to calculate size

Signed-off-by: Airat Arifullin a.arifullin@yadro.com

* Use methods to calculate size Signed-off-by: Airat Arifullin a.arifullin@yadro.com
aarifullin added the
enhancement
 label 2023-08-02 13:55:44 +00:00
aarifullin force-pushed feature/50-use_protowire from c13db54df5 to 173d95c0e7 2023-08-02 14:14:00 +00:00 Compare
aarifullin force-pushed feature/50-use_protowire from 173d95c0e7 to 542d2c64f7 2023-08-02 14:18:36 +00:00 Compare
aarifullin requested review from storage-core-developers 2023-08-02 14:21:20 +00:00
aarifullin requested review from storage-core-committers 2023-08-02 14:21:20 +00:00
aarifullin added the
refactoring
 label 2023-08-02 14:25:40 +00:00
acid-ant approved these changes 2023-08-02 14:48:25 +00:00
fyrchik reviewed 2023-08-02 15:29:15 +00:00
util/proto/marshal.go Outdated
@ -90,3 +89,1 @@
prefix := field << 3
return VarUIntSize(uint64(prefix)) + 1 // bool is always 1 byte long
return protowire.SizeGroup(protowire.Number(field), 1)
fyrchik commented 2023-08-02 15:29:15 +00:00
Owner

1 here and 0x1 at 80 worth a comment (or private constant)

`1` here and `0x1` at 80 worth a comment (or private constant)
👍 1
fyrchik approved these changes 2023-08-02 15:29:18 +00:00
aarifullin force-pushed feature/50-use_protowire from 542d2c64f7 to 553e8f673e 2023-08-03 07:23:49 +00:00 Compare
aarifullin requested review from acid-ant 2023-08-03 12:40:58 +00:00
aarifullin requested review from fyrchik 2023-08-10 07:16:24 +00:00
fyrchik approved these changes 2023-08-10 07:27:31 +00:00
fyrchik merged commit 9a7b47d769 into master 2023-08-10 16:40:55 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api-go#52
There is no content yet.
Delete Branch "aarifullin/frostfs-api-go:feature/50-use_protowire"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?