TrueCloudLab/frostfs-api-go
19
0
Fork 15
Code Issues 10 Pull requests Projects Releases Activity Actions

WIP: [#50] marshal: Use protowire append methods for marshalers #56

Closed
aarifullin wants to merge 1 commit from aarifullin/frostfs-api-go:feature/50-protowire_append into master
pull from: aarifullin/frostfs-api-go:feature/50-protowire_append
merge into: TrueCloudLab:master
Conversation 0 Commits 1 Files changed 16 +443 -590
aarifullin commented 2023-08-31 09:15:59 +00:00
Member
Copy link
  • Use protowire.AppendTag to encode a tag and append it
  • Use protowire.AppendVarint to append numeric data
  • Use protowire.AppendBytes and protowire.AppendString

Signed-off-by: Airat Arifullin a.arifullin@yadro.com

* Use protowire.AppendTag to encode a tag and append it * Use protowire.AppendVarint to append numeric data * Use protowire.AppendBytes and protowire.AppendString Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
aarifullin added the
refactoring
 label 2023-08-31 09:15:59 +00:00
aarifullin added 1 commit 2023-08-31 09:16:01 +00:00
[#50] marshal: Use protowire append methods for marshalers
Some checks failed
DCO action / DCO (pull_request) Successful in 48s
Details
Tests and linters / Tests (1.19) (pull_request) Failing after 59s
Details
Tests and linters / Tests with -race (pull_request) Successful in 1m31s
Details
Tests and linters / Tests (1.20) (pull_request) Failing after 5m52s
Details
Tests and linters / Lint (pull_request) Successful in 7m3s
Details
443098cb28 
* Use protowire.AppendTag to encode a tag and append it
* Use protowire.AppendVarint to append numeric data
* Use protowire.AppendBytes and protowire.AppendString

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
aarifullin requested review from storage-core-committers 2023-08-31 09:16:18 +00:00
aarifullin requested review from storage-core-developers 2023-08-31 09:16:19 +00:00
aarifullin requested review from storage-services-committers 2023-08-31 09:45:27 +00:00
aarifullin requested review from storage-services-developers 2023-08-31 09:45:28 +00:00
aarifullin changed title from [#50] marshal: Use protowire append methods for marshalers to WIP: [#50] marshal: Use protowire append methods for marshalers 2023-08-31 10:05:37 +00:00
aarifullin closed this pull request 2023-08-31 15:48:51 +00:00
Some checks failed
DCO action / DCO (pull_request) Successful in 48s
Details
Tests and linters / Tests (1.19) (pull_request) Failing after 59s
Details
Tests and linters / Tests with -race (pull_request) Successful in 1m31s
Details
Tests and linters / Tests (1.20) (pull_request) Failing after 5m52s
Details
Tests and linters / Lint (pull_request) Successful in 7m3s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
TrueCloudLab/storage-core-committers
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-committers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api-go#56
No description provided.
Delete branch "aarifullin/frostfs-api-go:feature/50-protowire_append"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?