Refactor sign/verify message #6
No reviewers
Labels
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-api-go#6
Loading…
Reference in New Issue
There is no content yet.
Delete Branch "dstepanov-yadro/feat/refactor-signservicemessage"
Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?
benchstat compare with master:
I think
api-go:
can be replaced with asignature:
in the commit header, it should designate a component in this repo (or omitted).Also I believe it should be
Verify parts IN parallel
.@ -0,0 +32,4 @@
case serviceResponse:
return verifyServiceResponse(v)
default:
panic(fmt.Sprintf("unsupported session message %T", v))
I am wondering if it makes sense to allocate once and use sub-slices here. Probably not, can bite us in an unexpected way.
Max
was here when we had a single buffer, do we need a singlesize
now?It seems to be used only from 1 package, why have you decided to exprort it?
Also, it isn't needed after parallelizations (see my later comment).
dropped
@ -0,0 +32,4 @@
case serviceResponse:
return verifyServiceResponse(v)
default:
panic(fmt.Sprintf("unsupported session message %T", v))
fixed
@ -0,0 +32,4 @@
case serviceResponse:
return verifyServiceResponse(v)
default:
panic(fmt.Sprintf("unsupported session message %T", v))
fixed
fixed
Superceeded by #8.
Pull request closed