object: Initial EC implementation #69

fyrchik · 2024-03-19T06:54:59Z

fyrchik commented

2024-03-19 06:54:59 +00:00

Signed-off-by: Evgenii Stratonikov e.stratonikov@yadro.com

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

fyrchik requested review from storage-core-committers 2024-03-19 06:55:35 +00:00

fyrchik requested review from storage-core-developers 2024-03-19 06:55:38 +00:00

fyrchik force-pushed erasure-code from 54a4bcdbe6 to d278046e72

2024-03-19 06:55:38 +00:00

Compare

fyrchik force-pushed erasure-code from d278046e72 to baa78b24ed

2024-03-19 07:58:06 +00:00

Compare

fyrchik force-pushed erasure-code from baa78b24ed to 5606868c3e

2024-03-19 08:55:05 +00:00

Compare

dstepanov-yadro requested changes 2024-03-19 09:11:01 +00:00

object/convert.go Outdated

					
				@ -594,0 +659,4 @@

					if s != nil {

						m = new(object.ECInfo)

						chunks := make([]*object.ECInfo_Chunk, len(s.Chunks))

dstepanov-yadro commented

2024-03-19 09:03:45 +00:00

If s.Chunks == nil, then m.Chunks == []*object.ECInfo_Chunk{}. But ECInfo.FromGRPCMessage has different implementation. Implementations should be the same.

If `s.Chunks == nil`, then `m.Chunks == []*object.ECInfo_Chunk{}`. But `ECInfo.FromGRPCMessage` has different implementation. Implementations should be the same.

fyrchik commented

2024-03-19 12:23:34 +00:00

Fixed, added tests for conversion.

object/types.go Outdated

					
				@ -1451,6 +1484,7 @@ func (b *PutSingleRequestBody) GetObject() *Object {

				}

				func (b *PutSingleRequestBody) SetObject(o *Object) {

					spew.Dump(o)