TrueCloudLab/frostfs-api-go
21
0
Fork 16
Code Issues 10 Pull requests 1 Projects Releases Activity Actions

netmap: Regenerate protobuf for Replica #70

Merged
fyrchik merged 1 commit from aarifullin/frostfs-api-go:fix/grpc_replica_ec_tags into master 2024-03-28 08:14:22 +00:00
Conversation 0 Commits 1 Files changed 2 +12
aarifullin commented 2024-03-26 14:13:22 +00:00
Member
Copy link
  • Since EC field tags are renumerated, it is required to regenerate netmap grpc.
  • Add a generator with EC replica to check it with unit-test.
* Since EC field tags are renumerated, it is required to regenerate netmap grpc. * Add a generator with EC replica to check it with unit-test.
aarifullin added the
bug
 label 2024-03-26 14:13:22 +00:00
aarifullin force-pushed fix/grpc_replica_ec_tags from 545e61fc0b to e35a8d103e 2024-03-26 14:13:47 +00:00 Compare
aarifullin requested review from storage-core-committers 2024-03-26 14:13:49 +00:00
aarifullin requested review from storage-core-developers 2024-03-26 14:13:50 +00:00
aarifullin force-pushed fix/grpc_replica_ec_tags from e35a8d103e to 5a5cee8d09 2024-03-26 14:14:37 +00:00 Compare
acid-ant approved these changes 2024-03-26 14:19:31 +00:00
achuprov approved these changes 2024-03-26 14:30:14 +00:00
aarifullin force-pushed fix/grpc_replica_ec_tags from 5a5cee8d09 to 491a47e7fe 2024-03-27 09:58:31 +00:00 Compare
aarifullin changed title from netmap: Use correct protobuf field tag numbers for EC to netmap: Regenerate protobuf for Replica 2024-03-27 09:59:22 +00:00
aarifullin requested review from acid-ant 2024-03-27 09:59:27 +00:00
aarifullin requested review from achuprov 2024-03-27 09:59:34 +00:00
acid-ant approved these changes 2024-03-27 10:24:35 +00:00
achuprov approved these changes 2024-03-27 11:15:01 +00:00
fyrchik approved these changes 2024-03-28 08:14:17 +00:00
fyrchik merged commit 491a47e7fe into master 2024-03-28 08:14:22 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
achuprov
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api-go#70
No description provided.
Delete branch "aarifullin/frostfs-api-go:fix/grpc_replica_ec_tags"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?