TrueCloudLab/frostfs-api-go
20
0
Fork 16
Code Issues 10 Pull requests 2 Projects Releases Activity Actions

apemanager: Generate protobufs for apemanager service #74

Merged
fyrchik merged 1 commit from aarifullin/frostfs-api-go:feat/apemanager into master 2024-05-02 11:53:29 +00:00
Conversation 0 Commits 1 Files changed 17 +1587
aarifullin commented 2024-04-24 15:18:51 +00:00
Member
Copy link
  • Generate protobufs from frostfs-api for APEManagerService;
  • Make marshallers, unmarshallers, json-encoders etc;
  • Create message encoding/decoding unit-tests etc.
* Generate protobufs from `frostfs-api` for `APEManagerService`; * Make marshallers, unmarshallers, json-encoders etc; * Create message encoding/decoding unit-tests etc.
aarifullin force-pushed feat/apemanager from 7e58c87445 to 990cbc305a 2024-04-24 15:19:26 +00:00 Compare
aarifullin requested review from storage-core-committers 2024-04-24 15:19:29 +00:00
aarifullin requested review from storage-core-developers 2024-04-24 15:19:44 +00:00
aarifullin force-pushed feat/apemanager from 990cbc305a to bd0c9bafb1 2024-04-24 15:33:07 +00:00 Compare
aarifullin force-pushed feat/apemanager from bd0c9bafb1 to a2db64e1e4 2024-04-24 15:51:48 +00:00 Compare
aarifullin force-pushed feat/apemanager from a2db64e1e4 to 27e4dd3bc7 2024-04-25 09:05:08 +00:00 Compare
aarifullin force-pushed feat/apemanager from 27e4dd3bc7 to 4d23ce6709 2024-04-25 09:15:34 +00:00 Compare
aarifullin force-pushed feat/apemanager from 4d23ce6709 to 029cd3a442 2024-04-25 16:53:25 +00:00 Compare
aarifullin force-pushed feat/apemanager from 029cd3a442 to 1525c57c14 2024-04-25 17:01:49 +00:00 Compare
aarifullin force-pushed feat/apemanager from 1525c57c14 to db157d9f5a 2024-04-25 18:02:05 +00:00 Compare
aarifullin force-pushed feat/apemanager from db157d9f5a to 0b97ae2857 2024-04-26 16:40:47 +00:00 Compare
dstepanov-yadro requested changes 2024-05-02 06:35:05 +00:00
apemanager/convert.go Outdated
@ -0,0 +119,4 @@
switch chainKind := mgrpc.GetKind().(type) {
default:
if err := fmt.Errorf("unsupported chain kind: %T", chainKind); err != nil {
dstepanov-yadro commented 2024-05-02 06:31:24 +00:00
Member
Copy link

I think it is the same as return fmt.Errorf("unsupported chain kind: %T", chainKind)

I think it is the same as `return fmt.Errorf("unsupported chain kind: %T", chainKind)`
fyrchik commented 2024-05-02 06:46:02 +00:00
Owner
Copy link

Exactly, fmt.Errorf never returns nil AFAIK

Exactly, `fmt.Errorf` never returns nil AFAIK
aarifullin commented 2024-05-02 07:43:09 +00:00
Author
Member
Copy link

Sorry, this non-sense has been left after mixed copy-paste. Fixed!

Sorry, this *non-sense* has been left after mixed copy-paste. Fixed!
dstepanov-yadro marked this conversation as resolved
aarifullin force-pushed feat/apemanager from 0b97ae2857 to 97e260b3fa 2024-05-02 07:42:50 +00:00 Compare
aarifullin requested review from dstepanov-yadro 2024-05-02 07:45:28 +00:00
dstepanov-yadro approved these changes 2024-05-02 07:51:52 +00:00
acid-ant approved these changes 2024-05-02 11:11:49 +00:00
fyrchik merged commit 387b850e5e into master 2024-05-02 11:53:29 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
acid-ant
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api-go#74
No description provided.
Delete branch "aarifullin/frostfs-api-go:feat/apemanager"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?