TrueCloudLab
/
frostfs-api-go
21
0
Fork 11
Code Issues 7 Pull Requests 1 Actions Releases Activity

object: Introduce new fields for v2 ECHeader #82

Merged
fyrchik merged 3 commits from aarifullin/frostfs-api-go:feat/ecHeader_parentSplit into master 2024-05-14 06:19:25 +00:00
Conversation 2 Commits 3 Files Changed 8
aarifullin commented 2024-05-08 12:08:54 +00:00
Collaborator
  • Erase field Signature from ECHeader v2 type as it has not been used at all
  • Regenerate protobufs as frostfs-api introduced parent_split_id and
    parent_split_index fields.
  • Fix marshaller and converter for EC header.
  • Extend v2 type ECHeader with ParentSplitID and ParentSplitIndex fields.
  • Fix message_test for Object. Also generate EC headers and check it.
  • Introduce FilterHeaderECParent filter name.
* Erase field `Signature` from `ECHeader` v2 type as it has not been used at all * Regenerate protobufs as frostfs-api introduced `parent_split_id` and `parent_split_index` fields. * Fix marshaller and converter for EC header. * Extend v2 type `ECHeader` with `ParentSplitID` and `ParentSplitIndex` fields. * Fix message_test for `Object`. Also generate EC headers and check it. * Introduce `FilterHeaderECParent` filter name.
aarifullin added 2 commits 2024-05-08 12:08:56 +00:00
2d67e67043 [#XX] object: Introduce new fields for EC header 
* Regenerate protobufs as frostfs-api introduced `parent_split_id` and
  `parent_split_index` fields.
* Fix marshaller and converter for EC header.
* Extend v2 type `ECHeader` with `ParentSplitID` and `ParentSplitIndex` fields.
* Fix message_test for `Object`. Also generate EC headers and check it.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
DCO action / DCO (pull_request) Failing after 58s Details
Tests and linters / Tests (1.20) (pull_request) Successful in 1m32s Details
Tests and linters / Tests (1.19) (pull_request) Successful in 1m58s Details
Tests and linters / Lint (pull_request) Successful in 2m6s Details
Tests and linters / Tests with -race (pull_request) Successful in 1m58s Details
f13b9a4d53 [#XX] object: Erase field `Signature` from `ECHeader` v2 type 
* The field `Signature` is not used and should be factored out.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
aarifullin force-pushed feat/ecHeader_parentSplit from f13b9a4d53 to 063ce11c24 2024-05-08 12:09:33 +00:00 Compare
aarifullin requested review from storage-core-committers 2024-05-08 12:10:18 +00:00
aarifullin requested review from storage-core-developers 2024-05-08 12:10:30 +00:00
fyrchik changed title from object: Introduce new fields for v2 `ECHeader` to WIP: object: Introduce new fields for v2 `ECHeader` 2024-05-08 13:08:37 +00:00
fyrchik commented 2024-05-08 13:08:57 +00:00
Owner

Depends on TrueCloudLab/frostfs-api#48

Depends on https://git.frostfs.info/TrueCloudLab/frostfs-api/pulls/48
dstepanov-yadro approved these changes 2024-05-08 13:15:07 +00:00
aarifullin changed title from WIP: object: Introduce new fields for v2 `ECHeader` to object: Introduce new fields for v2 `ECHeader` 2024-05-13 10:59:14 +00:00
fyrchik approved these changes 2024-05-13 11:01:13 +00:00
aarifullin added 1 commit 2024-05-13 14:05:06 +00:00
DCO action / DCO (pull_request) Successful in 1m0s Details
Tests and linters / Tests (1.20) (pull_request) Successful in 1m20s Details
Tests and linters / Tests (1.19) (pull_request) Successful in 1m30s Details
Tests and linters / Lint (pull_request) Successful in 1m53s Details
Tests and linters / Tests with -race (pull_request) Successful in 1m49s Details
4fe42ac4ad [#82] object: Add `FilterHeaderECParent` filter for v2 
* `FilterHeaderECParent` is used by `Object.Search`

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
aarifullin commented 2024-05-13 14:06:05 +00:00
Poster
Collaborator

FYI: I picked the filter name from PR #80 to this PR

FYI: I picked the filter name from PR [#80](https://git.frostfs.info/TrueCloudLab/frostfs-api-go/commit/87caff9c8df0d787356932cc6ba41056b21cc133) to this PR
aarifullin requested review from dstepanov-yadro 2024-05-13 14:06:45 +00:00
aarifullin requested review from fyrchik 2024-05-13 14:06:45 +00:00
fyrchik merged commit 4fe42ac4ad into master 2024-05-14 06:19:25 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api-go#82
There is no content yet.
Delete Branch "aarifullin/frostfs-api-go:feat/ecHeader_parentSplit"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?