TrueCloudLab/frostfs-api-go
22
0
Fork 16
Code Issues 10 Pull requests 2 Projects Releases Activity Actions

protogen: Support unpacked repeated uint64 fields #91

Merged
dstepanov-yadro merged 1 commit from fyrchik/frostfs-api-go:unpacked-primitive into master 2024-07-17 08:16:44 +00:00
Conversation 2 Commits 1 Files changed 4 +92 -6
fyrchik commented 2024-07-16 10:00:31 +00:00
Owner
Copy link

We need unpacked repeated fields to support backwards-compatible field "repeatization". Currently, we need this for tree service in node, so I have decided to implement this only for uint64 and don't create new exported functions in proto helper package.

We need unpacked repeated fields to support backwards-compatible field "repeatization". Currently, we need this for tree service in node, so I have decided to implement this only for uint64 and don't create new exported functions in `proto` helper package.
fyrchik added 1 commit 2024-07-16 10:00:49 +00:00
protogen: Support unpacked repeated uint64 fields
Some checks failed
DCO action / DCO (pull_request) Failing after 2m36s
Details
Tests and linters / Tests (1.19) (pull_request) Successful in 2m58s
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 2m57s
Details
Tests and linters / Lint (pull_request) Successful in 3m9s
Details
Tests and linters / Tests with -race (pull_request) Successful in 3m3s
Details
2a9bc571af 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik requested review from storage-core-committers 2024-07-16 10:02:38 +00:00
fyrchik force-pushed unpacked-primitive from 2a9bc571af to f517e39491 2024-07-16 11:39:36 +00:00 Compare
alexvanin approved these changes 2024-07-16 11:42:57 +00:00
alexvanin left a comment
Owner
Copy link

Does this change support packed attribute for any scalar proto3 type (int64, sint64, etc) or is it uint64 only?

Didn't read PR description, I see answer: uint64 only.

~~Does this change support packed attribute for any scalar proto3 type (`int64`, `sint64`, etc) or is it `uint64` only?~~ Didn't read PR description, I see answer: uint64 only.
fyrchik requested review from storage-core-developers 2024-07-16 11:43:04 +00:00
fyrchik requested review from storage-services-committers 2024-07-16 11:43:09 +00:00
fyrchik commented 2024-07-16 11:44:25 +00:00
Author
Owner
Copy link

or is it uint64 only?

Only uint64, as this is what we need currently. Supporting other types is trivial, but requires some amount of public API touching as well as poses a risk of introducing new bugs.

>or is it uint64 only? Only uint64, as this is what we need currently. Supporting other types is trivial, but requires some amount of public API touching as well as poses a risk of introducing new bugs.
dkirillov approved these changes 2024-07-16 12:00:05 +00:00
fyrchik commented 2024-07-16 12:02:47 +00:00
Author
Owner
Copy link

@TrueCloudLab/storage-core-committers @TrueCloudLab/storage-core-developers won't merge without your approval, please, support the development with your likes!

@TrueCloudLab/storage-core-committers @TrueCloudLab/storage-core-developers won't merge without your approval, please, support the development with your likes!
elebedeva approved these changes 2024-07-16 12:17:03 +00:00
aarifullin approved these changes 2024-07-16 13:57:28 +00:00
dstepanov-yadro approved these changes 2024-07-17 08:16:11 +00:00
dstepanov-yadro merged commit f517e39491 into master 2024-07-17 08:16:44 +00:00
fyrchik deleted branch unpacked-primitive 2024-07-17 08:30:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
dkirillov
elebedeva
aarifullin
dstepanov-yadro
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api-go#91
No description provided.
Delete branch "fyrchik/frostfs-api-go:unpacked-primitive"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?