protogen: Support unpacked repeated uint64 fields #91

Merged

dstepanov-yadro merged 1 commits from fyrchik/frostfs-api-go:unpacked-primitive into master

2024-07-17 08:16:44 +00:00

fyrchik commented

2024-07-16 10:00:31 +00:00

Owner

We need unpacked repeated fields to support backwards-compatible field "repeatization". Currently, we need this for tree service in node, so I have decided to implement this only for uint64 and don't create new exported functions in proto helper package.

fyrchik added 1 commit 2024-07-16 10:00:49 +00:00

DCO action / DCO (pull_request) Failing after 2m36s Details

Tests and linters / Tests (1.19) (pull_request) Successful in 2m58s Details

Tests and linters / Tests (1.20) (pull_request) Successful in 2m57s Details

Tests and linters / Lint (pull_request) Successful in 3m9s Details

Tests and linters / Tests with -race (pull_request) Successful in 3m3s Details

2a9bc571af protogen: Support unpacked repeated uint64 fields

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

fyrchik requested review from storage-core-committers 2024-07-16 10:02:38 +00:00

fyrchik force-pushed unpacked-primitive from 2a9bc571af to f517e39491

2024-07-16 11:39:36 +00:00

Compare

alexvanin approved these changes 2024-07-16 11:42:57 +00:00

alexvanin left a comment

Owner

~~Does this change support packed attribute for any scalar proto3 type (int64, sint64, etc) or is it uint64 only?~~

Didn't read PR description, I see answer: uint64 only.

~~Does this change support packed attribute for any scalar proto3 type (`int64`, `sint64`, etc) or is it `uint64` only?~~ Didn't read PR description, I see answer: uint64 only.

fyrchik requested review from storage-core-developers 2024-07-16 11:43:04 +00:00

fyrchik requested review from storage-services-committers 2024-07-16 11:43:09 +00:00

fyrchik commented

2024-07-16 11:44:25 +00:00

Poster

Owner

or is it uint64 only?

Only uint64, as this is what we need currently. Supporting other types is trivial, but requires some amount of public API touching as well as poses a risk of introducing new bugs.

>or is it uint64 only? Only uint64, as this is what we need currently. Supporting other types is trivial, but requires some amount of public API touching as well as poses a risk of introducing new bugs.

dkirillov approved these changes 2024-07-16 12:00:05 +00:00

fyrchik commented

2024-07-16 12:02:47 +00:00

Poster

Owner

@TrueCloudLab/storage-core-committers @TrueCloudLab/storage-core-developers won't merge without your approval, please, support the development with your likes!