TrueCloudLab/frostfs-api
32
0
Fork 18
Code Issues 14 Pull requests 2 Releases Activity Actions

[#77] object: Add a refinement to description on the FileName attribute #77

Open
r.loginov wants to merge 1 commit from r.loginov/frostfs-api:feature/update_filename_attribute_description into master
pull from: r.loginov/frostfs-api:feature/update_filename_attribute_description
merge into: TrueCloudLab:master
Conversation 1 Commits 1 Files changed 1 +2 -1
r.loginov commented 2025-02-05 10:41:57 +00:00
Member
Copy link

I wanted to re-gen the documentation, however I am getting the following error:

object/service.proto: is an editions file, but code generator protoc-gen-doc hasn't been updated to support editions yet.  Please ask the owner of this code generator to add support or switch back to proto2/proto3.

Can I manually correct the documentation or re-generate it to the state before the last commit?

UPD: Saw this comment. I will not re-genitize the documentation then.

Signed-off-by: Roman Loginov r.loginov@yadro.com

I wanted to re-gen the documentation, however I am getting the following error: ``` object/service.proto: is an editions file, but code generator protoc-gen-doc hasn't been updated to support editions yet. Please ask the owner of this code generator to add support or switch back to proto2/proto3. ``` Can I manually correct the documentation or re-generate it to the state before the [last commit](https://git.frostfs.info/TrueCloudLab/frostfs-api/commit/52e5bc646f1093be42581362a58e245734bdd8ac)? UPD: Saw [this](https://git.frostfs.info/TrueCloudLab/frostfs-api/pulls/77#issuecomment-66685) comment. I will not re-genitize the documentation then. Signed-off-by: Roman Loginov <r.loginov@yadro.com>
r.loginov self-assigned this 2025-02-05 10:41:57 +00:00
r.loginov added 1 commit 2025-02-05 10:41:58 +00:00
[#77] object: Add a refinement to description on the FileName attribute
All checks were successful
Formatters / Run fmt (pull_request) Successful in 24s
Details
DCO action / DCO (pull_request) Successful in 29s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 31s
Details
2ec8241d19 
Signed-off-by: Roman Loginov <r.loginov@yadro.com>
requested reviews from a.bogatyrev, alexvanin, realloc, fyrchik, storage-sdk-developers 2025-02-05 10:41:58 +00:00
alexvanin approved these changes 2025-02-06 10:03:27 +00:00
fyrchik commented 2025-02-06 13:26:25 +00:00
Owner
Copy link

#79 (comment)

https://git.frostfs.info/TrueCloudLab/frostfs-api/issues/79#issuecomment-66539
👍 1
All checks were successful
Formatters / Run fmt (pull_request) Successful in 24s
Details
DCO action / DCO (pull_request) Successful in 29s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 31s
Details
This pull request doesn't have enough approvals yet. 1 of 4 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u feature/update_filename_attribute_description:r.loginov-feature/update_filename_attribute_description
git checkout r.loginov-feature/update_filename_attribute_description
Sign in to join this conversation.
Reviewers
No reviewers
a.bogatyrev
realloc
fyrchik
alexvanin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
triage

Needs to be triaged

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
r.loginov
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api#77
No description provided.
Delete branch "r.loginov/frostfs-api:feature/update_filename_attribute_description"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?