TrueCloudLab/frostfs-api
25
0
Fork 14
Code Issues 10 Pull requests Releases Activity Actions

subnet: Drop fields and types #25

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-api:drop-subnet into master 2023-04-19 07:28:15 +00:00
Conversation 0 Commits 1 Files changed 9 +93 -229
dstepanov-yadro commented 2023-04-17 07:36:14 +00:00
Member
Copy link

Closes #21

Closes #21
dstepanov-yadro force-pushed drop-subnet from 9ba87be448 to ee909a5451 2023-04-17 07:37:41 +00:00 Compare
dstepanov-yadro force-pushed drop-subnet from ee909a5451 to 509e110547 2023-04-17 07:46:14 +00:00 Compare
dstepanov-yadro force-pushed drop-subnet from 509e110547 to a8a82ea691 2023-04-17 07:49:14 +00:00 Compare
dstepanov-yadro requested review from storage-core-committers 2023-04-17 07:49:52 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-04-17 07:49:52 +00:00
dstepanov-yadro force-pushed drop-subnet from a8a82ea691 to efc7a14851 2023-04-17 08:05:52 +00:00 Compare
dstepanov-yadro force-pushed drop-subnet from efc7a14851 to 7f59b8aaeb 2023-04-18 10:17:27 +00:00 Compare
fyrchik approved these changes 2023-04-18 10:18:07 +00:00
carpawell approved these changes 2023-04-18 15:04:58 +00:00
netmap/types.proto
@ -5,8 +5,6 @@ package neo.fs.v2.netmap;
option go_package = "git.frostfs.info/TrueCloudLab/frostfs-api-go/v2/netmap/grpc;netmap";
option csharp_namespace = "Neo.FileStorage.API.Netmap";
import "refs/types.proto";
carpawell commented 2023-04-18 15:04:56 +00:00
Member
Copy link

wondering whether you were attentive enough or your IDE removed that for you?

wondering whether you were attentive enough or your IDE removed that for you?
dstepanov-yadro commented 2023-04-18 15:58:17 +00:00
Author
Member
Copy link

IDE

IDE
👍 1
fyrchik approved these changes 2023-04-19 07:28:10 +00:00
fyrchik merged commit 7f59b8aaeb into master 2023-04-19 07:28:15 +00:00
fyrchik referenced this pull request from a commit 2023-04-19 07:28:16 +00:00
[#25] subnet: Drop fields and types
Sign in to join this conversation.
Reviewers
No reviewers
carpawell
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
triage

Needs to be triaged

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api#25
No description provided.
Delete branch "dstepanov-yadro/frostfs-api:drop-subnet"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?