TrueCloudLab/frostfs-api
28
0
Fork 17
Code Issues 11 Pull requests 1 Releases Activity Actions

Support erasure coding #41

Merged
fyrchik merged 3 commits from fyrchik/frostfs-api:erasure-code into master 2024-09-04 19:51:11 +00:00
Conversation 0 Commits 3 Files changed 3 +53
fyrchik commented 2024-03-14 07:13:15 +00:00
Owner
Copy link
No description provided.
fyrchik force-pushed erasure-code from c91cdc13a5 to f0d7fba8cc 2024-03-14 07:13:31 +00:00 Compare
fyrchik requested review from storage-core-committers 2024-03-14 07:13:39 +00:00
fyrchik requested review from storage-core-developers 2024-03-14 07:13:47 +00:00
acid-ant reviewed 2024-03-14 07:45:08 +00:00
object/service.proto Outdated
@ -680,1 +686,4 @@
SplitInfo split_info = 2;
// Meta information for EC object assembly.
ECInfo ec_info = 4;
acid-ant commented 2024-03-14 07:45:08 +00:00
Member
Copy link

4 here used intentionally?

`4` here used intentionally?
fyrchik commented 2024-03-14 07:55:21 +00:00
Author
Owner
Copy link

Hm, no, probably because of some intermediate refactoring, will fix.

Hm, no, probably because of some intermediate refactoring, will fix.
fyrchik commented 2024-03-14 07:56:39 +00:00
Author
Owner
Copy link

Fixed

Fixed
fyrchik commented 2024-03-14 07:57:04 +00:00
Author
Owner
Copy link

It was copypaste -- in other methods split_info is 3, so ec_info was 4.

It was copypaste -- in other methods `split_info` is 3, so `ec_info` was 4.
acid-ant approved these changes 2024-03-14 07:50:33 +00:00
fyrchik force-pushed erasure-code from f0d7fba8cc to f3ecfefff4 2024-03-14 07:56:39 +00:00 Compare
acid-ant approved these changes 2024-03-14 08:25:50 +00:00
aarifullin approved these changes 2024-03-18 11:08:41 +00:00
dstepanov-yadro requested changes 2024-03-18 12:09:24 +00:00
object/types.proto Outdated
@ -196,0 +205,4 @@
// Total number of chunks in this split.
uint32 total = 3 [ json_name = "total" ];
// Total length of a parent header. Used to trim padding zeroes.
uint32 header_length = 4 [ json_name = "header_length" ];
dstepanov-yadro commented 2024-03-18 12:09:12 +00:00
Member
Copy link

Why here json_name is in snake case uint32 header_length = 4 [ json_name = "header_length" ]; ?
But here uint32 ec_data_count = 6 [ json_name = "ecDataCount" ]; is camel case?

Why here json_name is in snake case ` uint32 header_length = 4 [ json_name = "header_length" ];` ? But here ` uint32 ec_data_count = 6 [ json_name = "ecDataCount" ];` is camel case?
fyrchik commented 2024-03-18 12:41:35 +00:00
Author
Owner
Copy link

header_length is my habit, ecDataCount is what we use in this repo
Fixed.

`header_length` is my habit, `ecDataCount` is what we use in this repo Fixed.
fyrchik force-pushed erasure-code from f3ecfefff4 to 46dd3885d2 2024-03-18 12:41:51 +00:00 Compare
dstepanov-yadro approved these changes 2024-03-18 12:42:51 +00:00
achuprov approved these changes 2024-03-18 13:07:16 +00:00
acid-ant approved these changes 2024-03-18 14:29:31 +00:00
fyrchik merged commit 46dd3885d2 into master 2024-03-19 06:54:07 +00:00
fyrchik deleted branch erasure-code 2024-03-19 06:54:08 +00:00
fyrchik referenced this pull request from a commit 2024-03-19 06:54:09 +00:00
[#41] object: Support erasure codes
fyrchik referenced this pull request from a commit 2024-03-19 06:54:09 +00:00
[#41] netmap: Support EC policy
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
dstepanov-yadro
achuprov
acid-ant
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
triage

Needs to be triaged

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api#41
No description provided.
Delete branch "fyrchik/frostfs-api:erasure-code"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?