TrueCloudLab/frostfs-api
26
0
Fork 17
Code Issues 11 Pull requests 1 Releases Activity Actions

netmap: Clarify MaxObjectSize parameter implication on object size #63

Merged
fyrchik merged 1 commit from a-savchuk/frostfs-api:doc-max-object-size into master 2024-10-26 11:30:28 +00:00
Conversation 0 Commits 1 Files changed 10 +118 -301
a-savchuk commented 2024-09-05 11:26:54 +00:00
Member
Copy link

Close #50

Signed-off-by: Aleksey Savchuk a.savchuk@yadro.com

Close #50 Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
a-savchuk added 3 commits 2024-09-05 11:26:54 +00:00 
Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
[#50] *: Regenerate docs
All checks were successful
DCO action / DCO (pull_request) Successful in 23s
Details
Formatters / Run fmt (pull_request) Successful in 41s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 41s
Details
810575e144 
Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
a-savchuk added 1 commit 2024-09-05 11:31:20 +00:00
test
Some checks failed
Formatters / Run fmt (pull_request) Successful in 20s
Details
DCO action / DCO (pull_request) Failing after 34s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 46s
Details
8780d30a3f
a-savchuk force-pushed doc-max-object-size from 8780d30a3f to b0415c455d 2024-09-05 11:32:49 +00:00 Compare
a-savchuk force-pushed doc-max-object-size from b0415c455d to 83bb8cc4ba 2024-09-05 11:40:17 +00:00 Compare
a-savchuk force-pushed doc-max-object-size from 83bb8cc4ba to 30f2eb344d 2024-09-05 11:45:24 +00:00 Compare
a-savchuk force-pushed doc-max-object-size from 30f2eb344d to 56bdadd74d 2024-09-05 11:53:10 +00:00 Compare
a-savchuk force-pushed doc-max-object-size from 56bdadd74d to c1eba27379 2024-09-05 11:54:57 +00:00 Compare
realloc reviewed 2024-09-05 12:52:31 +00:00
netmap/types.proto Outdated
@ -291,1 +291,4 @@
// Value: little-endian integer. Default: 0.
//
// This value refers to the maximum size of a **physically** stored object
// in NeoFS. However, from a user's perspective, the **logical** size of a
realloc commented 2024-09-05 12:52:31 +00:00
Owner
Copy link

FrostFS

FrostFS
a-savchuk commented 2024-09-05 13:02:31 +00:00
Author
Member
Copy link

But NeoFS is used throughout the documentation. Should I change all occurrences to keep it consistent?

But NeoFS is used throughout the documentation. Should I change all occurrences to keep it consistent?
fyrchik commented 2024-09-05 13:10:43 +00:00
Owner
Copy link

Yes, but in a separate commit, please

Yes, but in a separate commit, please
a-savchuk commented 2024-09-05 15:21:39 +00:00
Author
Member
Copy link

Done

Done
fyrchik reviewed 2024-09-05 12:55:00 +00:00
netmap/types.proto
@ -203,3 +203,2 @@
// * Continent \
// Node's continent name according to the [Seven-Continent model]
// (https://en.wikipedia.org/wiki/Continent#Number). Calculated
// Node's continent name according to the [Seven-Continent
fyrchik commented 2024-09-05 12:54:57 +00:00
Owner
Copy link

How could it be misformatted if we have just merged PR where actions were green?

How could it be misformatted if we have just merged PR where actions were green?
a-savchuk commented 2024-09-05 13:09:37 +00:00
Author
Member
Copy link

It's just an incorrectly formatted link e.g. [frostfs] (git.frostfs.info), where an extra space in the middle will cause it to render as-is, rather than as the intended frostfs. It's not the responsibility of current actions to check for such issues

It's just an incorrectly formatted link e.g. `[frostfs] (git.frostfs.info)`, where an extra space in the middle will cause it to render as-is, rather than as the intended [frostfs](git.frostfs.info). It's not the responsibility of current actions to check for such issues
👍 1
fyrchik marked this conversation as resolved
a-savchuk changed title from WIP: netmap: Clarify MaxObjectSize parameter implication on object size to netmap: Clarify MaxObjectSize parameter implication on object size 2024-09-05 13:02:35 +00:00
a-savchuk force-pushed doc-max-object-size from c1eba27379 to 2a46a9ea0a 2024-09-05 13:28:16 +00:00 Compare
aarifullin approved these changes 2024-09-06 07:24:44 +00:00
a-savchuk requested review from storage-core-developers 2024-09-06 07:34:01 +00:00
a-savchuk requested review from storage-core-committers 2024-09-06 07:34:02 +00:00
achuprov approved these changes 2024-09-06 07:48:10 +00:00
dstepanov-yadro approved these changes 2024-09-06 10:47:26 +00:00
fyrchik approved these changes 2024-09-06 13:35:48 +00:00
fyrchik merged commit 2a46a9ea0a into master 2024-09-06 13:35:57 +00:00
a-savchuk deleted branch doc-max-object-size 2024-11-02 13:45:27 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
achuprov
dstepanov-yadro
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
triage

Needs to be triaged

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api#63
No description provided.
Delete branch "a-savchuk/frostfs-api:doc-max-object-size"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?