TrueCloudLab/frostfs-api
25
0
Fork 14
Code Issues 10 Pull requests Releases Activity Actions

.forgejo: Make 'fmt' job fail on changed files #66

Merged
fyrchik merged 1 commit from a-savchuk/frostfs-api:fail-on-format into master 2024-09-13 12:22:04 +00:00
Conversation 0 Commits 1 Files changed 1 +3 -1
a-savchuk commented 2024-09-12 18:55:12 +00:00
Member
Copy link

Make the fmt job fail if any files have been formatted, inspired by TrueCloudLab/frostfs-node#1266. Debugged with this tool.

Signed-off-by: Aleksey Savchuk a.savchuk@yadro.com

Make the `fmt` job fail if any files have been formatted, inspired by https://git.frostfs.info/TrueCloudLab/frostfs-node/issues/1266. Debugged with [this tool](https://forgejo.org/docs/v1.20/user/actions/#debugging-workflows-with-forgejo-runner-exec). Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
a-savchuk added 1 commit 2024-09-12 18:55:12 +00:00
[#xx] .forgejo: Make 'fmt' job fail on changed files
Some checks failed
DCO action / DCO (pull_request) Failing after 26s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 26s
Details
Formatters / Run fmt (pull_request) Successful in 32s
Details
5174e9053f 
Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
a-savchuk force-pushed fail-on-format from 5174e9053f to c341226b07 2024-09-12 18:57:20 +00:00 Compare
a-savchuk changed title from WIP: .forgejo: Make 'fmt' job fail on changed files to .forgejo: Make 'fmt' job fail on changed files 2024-09-12 18:59:51 +00:00
a-savchuk requested review from storage-core-developers 2024-09-12 18:59:59 +00:00
a-savchuk requested review from storage-core-committers 2024-09-12 19:00:00 +00:00
acid-ant approved these changes 2024-09-12 19:01:58 +00:00
Dismissed
elebedeva approved these changes 2024-09-12 21:44:52 +00:00
Dismissed
elebedeva left a comment
Member
Copy link

Elegant solution!

Elegant solution!
achuprov approved these changes 2024-09-13 07:21:39 +00:00
Dismissed
fyrchik reviewed 2024-09-13 12:00:57 +00:00
.forgejo/workflows/fmt.yaml Outdated
@ -15,1 +15,3 @@
run: make fmt
run: |
make fmt
test -z "$(git diff --name-only)"
fyrchik commented 2024-09-13 12:00:57 +00:00
Owner
Copy link

--exit-code

Line 21 in TrueCloudLab/frostfs-contract@3e221b9
- name: Check that nothing has changed

`--exit-code` https://git.frostfs.info/TrueCloudLab/frostfs-contract/src/commit/3e221b973a3cfe387113990bab56b33f78bc0c18/.forgejo/workflows/codegen.yml#L21
a-savchuk commented 2024-09-13 12:13:03 +00:00
Author
Member
Copy link

Changed it

Changed it
fyrchik marked this conversation as resolved
a-savchuk force-pushed fail-on-format from c341226b07 to b2f5205976 2024-09-13 12:09:23 +00:00 Compare
a-savchuk dismissed acid-ant's review 2024-09-13 12:09:23 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

a-savchuk dismissed elebedeva's review 2024-09-13 12:09:23 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

a-savchuk dismissed achuprov's review 2024-09-13 12:09:23 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

elebedeva approved these changes 2024-09-13 12:10:53 +00:00
dstepanov-yadro approved these changes 2024-09-13 12:17:52 +00:00
fyrchik approved these changes 2024-09-13 12:22:00 +00:00
fyrchik merged commit b2f5205976 into master 2024-09-13 12:22:04 +00:00
a-savchuk deleted branch fail-on-format 2024-09-13 12:23:59 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
elebedeva
dstepanov-yadro
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
triage

Needs to be triaged

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api#66
No description provided.
Delete branch "a-savchuk/frostfs-api:fail-on-format"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?