container: Add ListStream method #70

Merged
fyrchik merged 2 commits from elebedeva/frostfs-api:feat/stream-for-list into master 2024-11-29 10:54:08 +00:00
Member
TrueCloudLab/frostfs-node#1452 Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>
elebedeva added 1 commit 2024-10-28 15:16:41 +00:00
[#XX] container: Add ListStream method
Some checks failed
Formatters / Run fmt (pull_request) Successful in 26s
Pre-commit hooks / Pre-commit (pull_request) Successful in 57s
DCO action / DCO (pull_request) Failing after 1m2s
a14a8281bf
Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>
elebedeva changed title from WIP: [#XX] container: Add ListStream method to WIP: container: Add ListStream method 2024-10-28 15:19:49 +00:00
elebedeva force-pushed feat/stream-for-list from a14a8281bf to b1c4f02946 2024-11-13 11:28:19 +00:00 Compare
elebedeva changed title from WIP: container: Add ListStream method to container: Add ListStream method 2024-11-13 11:28:33 +00:00
acid-ant reviewed 2024-11-13 12:18:02 +00:00
@ -62,2 +62,4 @@
// container list access denied.
rpc List(ListRequest) returns (ListResponse);
// Returns all owner's containers from 'Container` smart contract' storage
Member
'Container` smart contract' storage -> `Container` smart contract storage
``` 'Container` smart contract' storage -> `Container` smart contract storage ```
Author
Member

Fixed

Fixed
elebedeva force-pushed feat/stream-for-list from b1c4f02946 to eba1a55f88 2024-11-13 12:41:48 +00:00 Compare
elebedeva force-pushed feat/stream-for-list from eba1a55f88 to d3d8412323 2024-11-13 12:44:15 +00:00 Compare
elebedeva force-pushed feat/stream-for-list from d3d8412323 to efe46b28bc 2024-11-13 12:45:57 +00:00 Compare
acid-ant approved these changes 2024-11-13 12:58:54 +00:00
Dismissed
elebedeva requested review from storage-core-committers 2024-11-13 12:59:10 +00:00
elebedeva requested review from storage-core-developers 2024-11-13 12:59:12 +00:00
elebedeva requested review from storage-sdk-committers 2024-11-13 12:59:31 +00:00
fyrchik reviewed 2024-11-13 13:03:17 +00:00
@ -248,0 +261,4 @@
message ListStreamRequest {
// List containers stream request body.
message Body {
// Identifier of the container owner
Owner

There is no dot at the end, and I am now wondering why we do not check this.

There is no dot at the end, and I am now wondering why we do not check this.
orikik approved these changes 2024-11-13 13:03:26 +00:00
Dismissed
elebedeva force-pushed feat/stream-for-list from efe46b28bc to 8540f0d18d 2024-11-13 15:20:12 +00:00 Compare
elebedeva dismissed acid-ant's review 2024-11-13 15:20:13 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

elebedeva dismissed orikik's review 2024-11-13 15:20:13 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

acid-ant approved these changes 2024-11-13 16:40:27 +00:00
orikik approved these changes 2024-11-13 16:55:43 +00:00
aarifullin reviewed 2024-11-18 12:11:17 +00:00
@ -248,0 +295,4 @@
// Carries response verification information. This header is used to
// authenticate the nodes of the message route and check the correctness of
// transmission.
neo.fs.v2.session.ResponseVerificationHeader verify_header = 3;
Member

#69 had been merged last week. Since, we don't use neo.fs.v2 namespace - it does no longer exist. You'll probably encounter difficulties trying regenerate protobufs within frostfs-sdk-go/api.

I'd like to know the steps for an implementation of this method in frostfs-node. Should it be held for a while until all nodes bump frostfs-sdk-go version (in other words, all services will run handlers in the new namespace)?

[#69](https://git.frostfs.info/TrueCloudLab/frostfs-api/pulls/69) had been merged last week. Since, we don't use `neo.fs.v2` namespace - it does no longer exist. You'll probably encounter difficulties trying regenerate protobufs within `frostfs-sdk-go/api`. I'd like to know the steps for an implementation of this method in `frostfs-node`. Should it be held for a while until all nodes bump `frostfs-sdk-go` version (in other words, all services will run handlers in the new namespace)?
Member

Sorry, this comment is irrelevant as those PR was merged into non-master branch

Sorry, this comment is irrelevant as those PR was merged into non-master branch
aarifullin marked this conversation as resolved
aarifullin approved these changes 2024-11-27 15:25:37 +00:00
fyrchik merged commit 8540f0d18d into master 2024-11-29 10:54:08 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api#70
No description provided.