WIP: Lint and check protobuf schemas for breaking changes #72

Closed

potyarkin wants to merge 1 commit from potyarkin:feature/buf-workflow into master

potyarkin commented

2024-11-06 12:09:32 +00:00

Member

Old GitHub workflow was using wizhi/setup-buf, that repo is archived now.

In this PR I've added bufbuild/buf-action which works fine on our Forgejo instance, but it returns a lot of linter/formatter errors. I'm not even sure it got to the stage where it checks for breaking changes in my test runs.

Linter failures may also be caused by buf misconfiguration on my part, I'm a complete noob when it comes to protobufs. Will look into this further, but also hope for helpful suggestions from more experienced peers.

Old GitHub workflow was using [wizhi/setup-buf](https://github.com/wizhi/setup-buf), that repo is archived now. In this PR I've added [bufbuild/buf-action](https://github.com/bufbuild/buf-action) which works fine on our Forgejo instance, but it returns a lot of linter/formatter errors. I'm not even sure it got to the stage where it checks for breaking changes in my [test runs](https://git.frostfs.info/potyarkin/frostfs-api/actions/runs/13/jobs/0). Linter failures may also be caused by `buf` misconfiguration on my part, I'm a complete noob when it comes to protobufs. Will look into this further, but also hope for helpful suggestions from more experienced peers.

potyarkin added 1 commit 2024-11-06 12:09:32 +00:00

[#] Lint and check protobuf schemas for breaking changes

Buf check / buf (pull_request) Failing after 34s

Details

Formatters / Run fmt (pull_request) Successful in 40s

Details

DCO action / DCO (pull_request) Failing after 55s

Details

Pre-commit hooks / Pre-commit (pull_request) Successful in 1m3s

Details

cb1504cef8

Signed-off-by: Vitaliy Potyarkin <v.potyarkin@yadro.com>

potyarkin force-pushed feature/buf-workflow from cb1504cef8 to 4f2fa0ee8c

2024-11-06 12:12:16 +00:00

Compare

fyrchik commented

2024-11-06 12:24:37 +00:00

Owner

We have stayed with clang-format instead of buf fmt, because buf is unavailable from Russia, hence action failure.

We have stayed with `clang-format` instead of `buf fmt`, because buf is unavailable from Russia, hence action failure.

potyarkin commented

2024-11-06 13:04:08 +00:00

Author

Member

I've noticed that buf documentation is not available from Russia but this is not the reason the action fails: buf runs fine and produces than 1000 lines of minor formatting nitpicks (mostly whitespace changes, option/import ordering improvements).

If we have migrated away from buf and clang-format covers our needs now - I can drop this PR.

I've noticed that `buf` documentation is not available from Russia but this is not the reason [the action fails](https://git.frostfs.info/TrueCloudLab/frostfs-api/actions/runs/95/jobs/0): buf runs fine and produces than 1000 lines of minor formatting nitpicks (mostly whitespace changes, option/import ordering improvements). If we have migrated away from buf and clang-format covers our needs now - I can drop this PR.