TrueCloudLab/frostfs-api
28
0
Fork 17
Code Issues 11 Pull requests 1 Releases Activity Actions

Use edition directive instead of syntax #74

Open
fyrchik wants to merge 1 commit from fyrchik/frostfs-api:edition into master
pull from: fyrchik/frostfs-api:edition
merge into: TrueCloudLab:master
Conversation 2 Commits 1 Files changed 17 +17 -17
fyrchik commented 2024-12-26 11:07:20 +00:00
Owner
Copy link

https://go.dev/blog/protobuf-opaque

Signed-off-by: Evgenii Stratonikov e.stratonikov@yadro.com

https://go.dev/blog/protobuf-opaque Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik added 1 commit 2024-12-26 11:07:21 +00:00
Use edition directive instead of syntax
Some checks failed
DCO action / DCO (pull_request) Failing after 1m43s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m50s
Details
Formatters / Run fmt (pull_request) Successful in 2m2s
Details
f1ef3714e4 
https://go.dev/blog/protobuf-opaque

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik requested review from alexvanin 2024-12-26 11:07:21 +00:00
fyrchik requested review from realloc 2024-12-26 11:07:21 +00:00
fyrchik requested review from a.bogatyrev 2024-12-26 11:07:21 +00:00
fyrchik requested review from storage-sdk-committers 2024-12-26 11:09:40 +00:00
fyrchik force-pushed edition from f1ef3714e4 to 1dedbc3fa5 2024-12-26 11:09:57 +00:00 Compare
dstepanov-yadro commented 2024-12-27 14:04:40 +00:00
Member
Copy link

Is this supported by go protobuf, or is there support for other programming languages too?

Is this supported by go protobuf, or is there support for other programming languages too?
fyrchik commented 2024-12-28 05:42:06 +00:00
Author
Owner
Copy link

For everything https://protobuf.dev/editions/overview/

For everything https://protobuf.dev/editions/overview/
👍 1
dstepanov-yadro approved these changes 2024-12-28 06:35:53 +00:00
fyrchik requested review from orikik 2024-12-28 06:42:42 +00:00
fyrchik requested review from PavelGrossSpb 2024-12-28 06:42:43 +00:00
All checks were successful
Formatters / Run fmt (pull_request) Successful in 2m13s
Details
DCO action / DCO (pull_request) Successful in 2m21s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 2m25s
Details
This pull request doesn't have enough approvals yet. 1 of 4 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u edition:fyrchik-edition
git checkout fyrchik-edition
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
realloc
a.bogatyrev
dstepanov-yadro
orikik
PavelGrossSpb
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
triage

Needs to be triaged

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-api#74
No description provided.
Delete branch "fyrchik/frostfs-api:edition"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?