TrueCloudLab/frostfs-contract
24
0
Fork 19
Code Issues 16 Pull requests Projects Releases 2 Activity Actions

Update neo-go, minor fixes #113

Merged
fyrchik merged 3 commits from fyrchik/frostfs-contract:update-neogo into master 2024-11-02 14:21:47 +00:00
Conversation 1 Commits 3 Files changed 4 +122 -619
fyrchik commented 2024-09-09 06:31:38 +00:00
Owner
Copy link
No description provided.
fyrchik added 3 commits 2024-09-09 06:31:38 +00:00 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Regenerate wrappers
Some checks failed
Tests / Tests (pull_request) Failing after 46s
Details
DCO action / DCO (pull_request) Failing after 50s
Details
c18b9a0e11 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik added this to the v0.20.0 milestone 2024-09-09 06:31:46 +00:00
fyrchik requested review from storage-core-committers 2024-09-09 06:31:52 +00:00
fyrchik requested review from storage-core-developers 2024-09-09 06:31:53 +00:00
fyrchik requested review from storage-services-committers 2024-09-09 06:31:54 +00:00
fyrchik requested review from storage-services-developers 2024-09-09 06:31:55 +00:00
fyrchik force-pushed update-neogo from c18b9a0e11 to 873630f71d 2024-09-09 06:32:08 +00:00 Compare
acid-ant approved these changes 2024-09-09 06:33:44 +00:00
Dismissed
fyrchik force-pushed update-neogo from 873630f71d to a7632d1c9f 2024-09-09 06:35:07 +00:00 Compare
fyrchik dismissed acid-ant's review 2024-09-09 06:35:07 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

fyrchik force-pushed update-neogo from a7632d1c9f to d4323bb0d1 2024-09-09 06:37:20 +00:00 Compare
fyrchik force-pushed update-neogo from d4323bb0d1 to f4cc2d62ac 2024-09-09 06:41:59 +00:00 Compare
fyrchik requested review from storage-core-committers 2024-09-09 06:43:19 +00:00
fyrchik force-pushed update-neogo from f4cc2d62ac to a3c74e4fbb 2024-09-09 06:44:10 +00:00 Compare
fyrchik force-pushed update-neogo from a3c74e4fbb to a2270adbdb 2024-09-09 06:47:14 +00:00 Compare
acid-ant approved these changes 2024-09-09 06:48:24 +00:00
Dismissed
fyrchik force-pushed update-neogo from a2270adbdb to 597cffd353 2024-09-09 06:51:11 +00:00 Compare
fyrchik dismissed acid-ant's review 2024-09-09 06:51:11 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

fyrchik force-pushed update-neogo from 597cffd353 to 6b7ce787f4 2024-09-09 06:53:42 +00:00 Compare
achuprov approved these changes 2024-09-09 06:55:21 +00:00
Dismissed
fyrchik added 1 commit 2024-09-09 06:55:45 +00:00
[#113] Regenerate wrappers
Some checks failed
DCO action / DCO (pull_request) Successful in 37s
Details
Code generation / Generate wrappers (pull_request) Failing after 46s
Details
Tests / Tests (pull_request) Successful in 1m7s
Details
c66b166f94 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik dismissed achuprov's review 2024-09-09 06:55:45 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

fyrchik added 1 commit 2024-09-09 06:58:24 +00:00
test
Some checks failed
DCO action / DCO (pull_request) Failing after 23s
Details
Tests / Tests (pull_request) Successful in 1m12s
Details
Code generation / Generate wrappers (pull_request) Successful in 1m16s
Details
932a53d6d4 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik force-pushed update-neogo from 932a53d6d4 to 7b2e34395e 2024-09-09 06:59:16 +00:00 Compare
fyrchik force-pushed update-neogo from 7b2e34395e to ba7c1196ad 2024-09-09 07:10:25 +00:00 Compare
fyrchik force-pushed update-neogo from ba7c1196ad to b566e2d563 2024-09-09 07:11:38 +00:00 Compare
fyrchik force-pushed update-neogo from b566e2d563 to 5d552caf5d 2024-09-09 07:12:13 +00:00 Compare
fyrchik force-pushed update-neogo from 5d552caf5d to 56a8e7d305 2024-09-09 07:14:36 +00:00 Compare
fyrchik force-pushed update-neogo from 56a8e7d305 to cb82d2eac8 2024-09-09 07:20:36 +00:00 Compare
fyrchik force-pushed update-neogo from cb82d2eac8 to 3e221b973a 2024-09-09 07:27:13 +00:00 Compare
fyrchik commented 2024-09-09 07:28:52 +00:00
Author
Owner
Copy link

I have removed .gitattributes to be able to catch non-deterministic autogeneration behaviour, see this run https://git.frostfs.info/TrueCloudLab/frostfs-contract/actions/runs/482 -- all files were changed.
It happend twice, but I wasn't able to reproduce.
If it happens again, we will have diff and can create an issue in neo-go.
After that we can mark these files as -diff in .gitattributes.

I have removed `.gitattributes` to be able to catch non-deterministic autogeneration behaviour, see this run https://git.frostfs.info/TrueCloudLab/frostfs-contract/actions/runs/482 -- all files were changed. It happend _twice_, but I wasn't able to reproduce. If it happens again, we will have diff and can create an issue in neo-go. After that we can mark these files as `-diff` in `.gitattributes`.
fyrchik requested review from storage-core-committers 2024-09-09 07:29:03 +00:00
fyrchik requested review from storage-core-developers 2024-09-09 07:29:03 +00:00
achuprov approved these changes 2024-09-09 07:34:40 +00:00
aarifullin approved these changes 2024-09-09 07:34:50 +00:00
fyrchik merged commit 3e221b973a into master 2024-09-09 08:27:56 +00:00
fyrchik deleted branch update-neogo 2024-09-09 08:27:57 +00:00
fyrchik referenced this pull request from a commit 2024-09-09 08:27:58 +00:00
[#113] go.mod: Update neo-go
fyrchik referenced this pull request from a commit 2024-09-09 08:27:58 +00:00
[#113] Regenerate wrappers
Sign in to join this conversation.
Reviewers
No reviewers
achuprov
aarifullin
TrueCloudLab/storage-services-committers
TrueCloudLab/storage-services-developers
TrueCloudLab/storage-core-committers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.20.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-contract#113
No description provided.
Delete branch "fyrchik/frostfs-contract:update-neogo"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?