TrueCloudLab/frostfs-contract
23
0
Fork 19
Code Issues 18 Pull requests Projects Releases 3 Activity Actions

frostfsid: Make migration idempotent #135

Merged
fyrchik merged 1 commit from achuprov/frostfs-contract:bugfix/frostfsid_migration into master 2024-12-12 06:28:20 +00:00
Conversation 0 Commits 1 Files changed 1 +3 -1
achuprov commented 2024-12-05 14:17:41 +00:00
Member
Copy link
No description provided.
achuprov added 3 commits 2024-12-05 14:17:41 +00:00 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
[#135] common: Update version
All checks were successful
DCO action / DCO (pull_request) Successful in 54s
Details
Code generation / Generate wrappers (pull_request) Successful in 1m59s
Details
Tests / Tests (pull_request) Successful in 2m4s
Details
d1b0bd3676 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
requested reviews from fyrchik, storage-core-developers, storage-core-committers 2024-12-05 14:17:41 +00:00
achuprov reviewed 2024-12-05 14:24:28 +00:00
tests/frostfsid_test.go Outdated
@ -652,0 +693,4 @@
updateContractFail(t, c1, e, c.Hash, args, "frostfsid contract contains duplicate keys")
invoker.Invoke(t, stackitem.Null{}, deleteSubjectMethod, subjBKeyAddr)
updateContract(t, c1, e, c.Hash, args)
updateContract(t, c1, e, c.Hash, args)
achuprov commented 2024-12-05 14:24:28 +00:00
Author
Member
Copy link

Сheck idempotency of the update

Сheck idempotency of the `update`
fyrchik reviewed 2024-12-06 03:52:29 +00:00
tests/frostfsid_test.go Outdated
@ -651,1 +652,4 @@
const frostfsidContractName = "frostfsid"
func TestFrostfsid_Migration(t *testing.T) {
fyrchik commented 2024-12-06 03:52:29 +00:00
Owner
Copy link

This is one time test, I do not see it being useful.
Could you remove it?

This is one time test, I do not see it being useful. Could you remove it?
fyrchik marked this conversation as resolved
fyrchik reviewed 2024-12-06 03:53:07 +00:00
common/version.go Outdated
@ -12,3 +12,3 @@
// any migration routines.
prevMajor = 0
prevMinor = 20
prevMinor = 21
fyrchik commented 2024-12-06 03:53:07 +00:00
Owner
Copy link

21.0 is not deployed anywhere, we will definitely update on 21.1 in one step

21.0 is not deployed anywhere, we will definitely update on 21.1 in one step
achuprov marked this conversation as resolved
achuprov force-pushed bugfix/frostfsid_migration from d1b0bd3676 to cb5dc744a3 2024-12-06 11:49:21 +00:00 Compare
fyrchik reviewed 2024-12-06 12:21:41 +00:00
frostfsid/frostfsid_contract.go Outdated
@ -116,2 +116,3 @@
if isUpdate {
it := storage.Find(ctx, subjectKeysPrefix, storage.ValuesOnly)
it := storage.Find(ctx, addressPrefix, storage.KeysOnly)
migrationCompleted := false
fyrchik commented 2024-12-06 12:21:07 +00:00
Owner
Copy link

What do you need this flag for?

What do you need this flag for?
achuprov commented 2024-12-06 12:36:29 +00:00
Author
Member
Copy link

This flag means that contracts do not contain keys with addressPrefix. There are only two possible cases: either the contract does not contain subjects, or the migration wasn't executed. In both cases, the Update operation is idempotent

This flag means that contracts do not contain keys with `addressPrefix`. There are only two possible cases: either the contract does not contain subjects, or the migration wasn't executed. In both cases, the `Update` operation is idempotent
fyrchik commented 2024-12-06 13:28:02 +00:00
Owner
Copy link

In what situation can it be true?

In what situation can it be true?
achuprov commented 2024-12-06 13:41:44 +00:00
Author
Member
Copy link

The flag can be set to true if the deploy is run again after migration

The flag can be set to true if the `deploy` is run again after migration
fyrchik commented 2024-12-06 16:42:58 +00:00
Owner
Copy link

It runs only on update.
The not-run-twice logic is achived via Version variables.

It runs only on update. The not-run-twice logic is achived via Version variables.
👍 1
fyrchik marked this conversation as resolved
achuprov force-pushed bugfix/frostfsid_migration from cb5dc744a3 to 871aa280b4 2024-12-10 18:24:41 +00:00 Compare
fyrchik reviewed 2024-12-11 10:16:47 +00:00
frostfsid/frostfsid_contract.go Outdated
@ -102,18 +102,17 @@ const (
func _deploy(data any, isUpdate bool) {
ctx := storage.GetContext()
args := data.(struct {
fyrchik commented 2024-12-11 10:16:47 +00:00
Owner
Copy link

This is unrelated to the commit.

This is unrelated to the commit.
fyrchik marked this conversation as resolved
achuprov force-pushed bugfix/frostfsid_migration from 871aa280b4 to 776b36499d 2024-12-11 15:38:27 +00:00 Compare
achuprov force-pushed bugfix/frostfsid_migration from 776b36499d to 9544465be3 2024-12-11 15:40:40 +00:00 Compare
achuprov force-pushed bugfix/frostfsid_migration from 9544465be3 to bc31d591e8 2024-12-11 15:42:42 +00:00 Compare
achuprov force-pushed bugfix/frostfsid_migration from bc31d591e8 to 01597b5dde 2024-12-12 06:18:47 +00:00 Compare
fyrchik approved these changes 2024-12-12 06:20:47 +00:00
fyrchik merged commit a3021f18cf into master 2024-12-12 06:28:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-contract#135
No description provided.
Delete branch "achuprov/frostfs-contract:bugfix/frostfsid_migration"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?